Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #18154][V4] Add test unit to check logic of ignoreBackdropClick #18245

Merged
merged 1 commit into from
Nov 26, 2016
Merged

[Fix #18154][V4] Add test unit to check logic of ignoreBackdropClick #18245

merged 1 commit into from
Nov 26, 2016

Conversation

Johann-S
Copy link
Member

Hi,

Closes #18154

@Johann-S
Copy link
Member Author

Travis failed on rvm install 2.2

@cvrebert
Copy link
Collaborator

Reopened travis-ci/travis-ci#5092

@Johann-S
Copy link
Member Author

FYI all tests passed in my environnement

@Johann-S
Copy link
Member Author

Maybe this PR #18903 had fixed the issue so I can rebase to try to run again all tests @cvrebert ?

@cvrebert
Copy link
Collaborator

@Johann-S Go for it 😄

@Johann-S
Copy link
Member Author

All tests passed 😄

@mdo mdo added this to the v4.0.0-alpha.6 milestone Nov 26, 2016
@mdo mdo merged commit ce18a66 into twbs:v4-dev Nov 26, 2016
@mdo
Copy link
Member

mdo commented Nov 26, 2016

<3<3<3

@mdo mdo mentioned this pull request Nov 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bardiharborow bardiharborow bardiharborow approved these changes

Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
v4.0.0-alpha.6
Development

Successfully merging this pull request may close these issues.
4 participants
@Johann-S @cvrebert @mdo @bardiharborow