Follow up to reverted commits #11928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atting consistency
| * Breaking backwards compatibility bumps the major | ||
| * New additions without breaking backwards compatibility bumps the minor | ||
| * Bug fixes and misc changes bump the patch | ||
| - **Breaking backwards compatibility **bumps the major** while resetting minor and patch |
There was a problem hiding this comment.
Two asterisks at the beginning don't belong there.
ghost
assigned
| * New additions without breaking backwards compatibility bumps the minor | ||
| * Bug fixes and misc changes bump the patch | ||
| - **Breaking backwards compatibility **bumps the major** while resetting minor and patch | ||
| - New additions without breaking backwards compatibility **bumps the minor** while resetting the patch |
There was a problem hiding this comment.
When used as an adverb, there is never an s in backward. Applies to new lines 142 and 143.
|
🚢 🇮🇹 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes everything we broke by reverting those commits in #11927.
/cc @twbs/team