Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expansion of "Customizing Bootstrap", extending using compiled CSS strategy. #10509

Closed
wants to merge 7 commits into from
Closed

Conversation

StevenBlack
Copy link
Contributor

See my current branch live, in action here: http://bs3.sbc.io/getting-started/#customizing.

In summary:

  • replaced the brief .bs-callout-info segment -- which was a placeholder anyway -- with an expanded description of Bootstrap's CSS development process. This clarifies that the user has 2 hooks: either customize at the .LESS stage, or customize using the compiled CSS.
  • Expanded on the strategy of extending the compiled CSS.
  • Put the component customization example in an info-panel.
  • Renamed the "Removing potential bloat" section to "Controlling bloat" and placed that in its own danger-panel.

This is just a start but I reckon this is usable right now, way better than what we currently have.

Coming soon would be an equal treatment about customizing at the LESS stage, and perhaps a short table comparing and contrasting the two strategies.

…nd akward) .bs-callout-info segment with an expanded description of the base Bootstrap CSS development process
A major overhaul of the "Customizing Bootstrap" section including:

* Expanded on the strategy of extending the compiled CSS.
* Placing the component customization example in an info-panel.
* Renaming the "Removing potential bloat" section to "Controlling bloat" and placing that in its own danger-panel.
<p class="lead">Bootstrap is best maintained as a separately versioned package in your development environment. This makes updating and upgrading Bootstrap easier in the future. To customize Bootstrap, create a new stylesheet, using LESS or just plain CSS, to house your customizations.</p>

<p>Bootstrap's developers use the following steps to author and assemble CSS. This knowledge may help you pick a customization strategy that's right for you.</p>
<p><strong>First the CSS source code is authored and maintained in LESS files</strong> named for their functionality. For example, in files named <code>grid.less</code>, <code>forms.less</code>, and many others. If you are comfortable using build tools, then consider using LESS to customize Bootstrap.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"First, the..."

The second sentence here sounds incomplete. Perhaps use "For example, in grid.less you'll find the code for generating our grid system's CSS."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@mdo
Copy link
Member

mdo commented Sep 9, 2013

Let's stick with the callouts for now instead of the panels, btw. I've tweaked their style a bit in master, so that should help with the longer blocks of text and other content.

@mdo
Copy link
Member

mdo commented Sep 9, 2013

Also, <3—thanks!

…; did this wherever it made lexical sense. The remaining instances of 'compiled' are actions, not adjectives.
@StevenBlack
Copy link
Contributor Author

Ping.

Wondering, is this PR good-to-go? I think I got everything. Anything else?

@StevenBlack
Copy link
Contributor Author

Ping

This PR seems stalled for some reason.

I'd like to continue improving getting-started.html, specifically appending a section on extending Bootstrap at the Less stage. But this expansion of extending Bootstrap at the CSS stage comes first. It's predicate.

The state of getting-started.html given this Pull Request is live here: http://bs3.sbc.io/getting-started/#customizing

So may I ask, please pull it before merging becomes a pain, close it so I know it's dead, or tell me what's needed to continue this PR forward.

@cvrebert
Copy link
Collaborator

The HTML validator says you have an extra unmatched </div> (see Travis build log).

@StevenBlack
Copy link
Contributor Author

Good catch @cvrebert. Fixed. And a few other things tidied as well.

@cvrebert
Copy link
Collaborator

/cc @mdo

@StevenBlack
Copy link
Contributor Author

A Git question: This pull request is nearly three weeks old now. What's the best workflow to merge or rebase this branch against master so it remains viable, and an easy-pull, without screwing-up?

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants