typeahead: ignore some keys

[benjaminclot]

Hi,

When a typeahead is filled with enough characters (more than minLength), if you only hit the SHIFT key, lookup() is called. I think it should be ignored, along with some other keys (CTRL, ALT, ALTGR...). Or ignore any input that doesn't alter the value of the query or its length?

Benjamin

[andrewdeandrade]

Hey @benjaminclot,

Thanks for opening this issue! Unfortunately, it looks like it fails to pass the criteria neccessary for submitting to bootstrap. The following things are currently failing:

• should include a jsfiddle/jsbin illustrating the problem if tagged with js but not a feature

For a full list of issue filing guidelines, please refer to the bootstrap issue filing guidelines.

thanks!

[benjaminclot]

Hi @malandrew,

I don't see how any jsfiddle/jsbin would be relevant? I use an ajax source and clearly see ajax calls each time I hit SHIFT or CTRL or ALT... I guess you could console.log on each lookup().

[blakeembrey]

@benjaminclot That comment is usually a result of someone running make haunt. Anyway, this sounds like a good idea though so I will look at implementing it later this week if you haven't already - would definitely be handy when using ajax.

[benjaminclot]

@blakeembrey Exactly, that's how I saw this, using Ajax. I guess ignoring keys #16 (Shift), #17 (Ctrl) and #18 (Alt) along with #38 (up arrow) and #40 (down arrow) on keyup() would be enough. I'll try and attach a fix suggestion.

EDIT: here it is #5546

[fat]

adding the ignore keys in 2.1.2 thanks guys