Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter/Facebook Image not showing (broken image link) #26637

Closed
coliff opened this issue May 31, 2018 · 3 comments
Closed

Twitter/Facebook Image not showing (broken image link) #26637

coliff opened this issue May 31, 2018 · 3 comments

Comments

@coliff
Copy link
Contributor

coliff commented May 31, 2018

I noticed that the image doesn't show in the Twitter Card when sharing a link to the Bootstrap Docs on Twitter. (e.g. https://twitter.com/christianoliff/status/1002077097844621312).

I see in the docs markup the following:
<meta name="twitter:image" content="https://getbootstrap.com/assets/brand/bootstrap-social-logo.png">
but https://getbootstrap.com/assets/brand/bootstrap-social-logo.png is broken link.

Same issue wtih Facebook sharing since the same image is referenced:
<meta property="og:image" content="http://getbootstrap.com/assets/brand/bootstrap-social.png">

Do the Twitter Card / OpenGraph image links need updating to the following?
http://getbootstrap.com/docs/4.1/assets/brand/bootstrap-social.png

@XhmikosR
Copy link
Member

XhmikosR commented Jun 1, 2018

The docs refactoring is again to blame...

/CC @mdo

@mdo
Copy link
Member

mdo commented Jun 27, 2018

Fixed in live docs.

mdo added a commit that referenced this issue Jun 27, 2018
@mdo
Copy link
Member

mdo commented Jun 27, 2018

Proper fix coming in #26732.

@mdo mdo added the has-pr label Jun 27, 2018
XhmikosR pushed a commit that referenced this issue Jun 27, 2018
XhmikosR pushed a commit that referenced this issue Jul 8, 2018
XhmikosR pushed a commit that referenced this issue Jul 12, 2018
mdo added a commit that referenced this issue Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants