Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size mixin #25752

Closed
MartijnCuppens opened this issue Mar 1, 2018 · 6 comments
Closed

Size mixin #25752

MartijnCuppens opened this issue Mar 1, 2018 · 6 comments

Comments

@MartijnCuppens
Copy link
Member

The size mixin is not documented in the docs.

// Sizing shortcuts
@mixin size($width, $height: $width) {
width: $width;
height: $height;
}

Shall we:

  • document this
  • or remove the mixin (width and height are not the most complex properties to remember)
@XhmikosR
Copy link
Member

I think we should drop this, but let's hear @mdo's thoughts too.

MartijnCuppens added a commit to MartijnCuppens/bootstrap that referenced this issue Mar 14, 2018
@Kopyov
Copy link
Contributor

Kopyov commented Mar 14, 2018

I personally find it very useful, especially in complex SCSS files.

@kevinruscoe
Copy link
Contributor

Not sure why anyone would want to drop this? It's not like it increases build sizes or anything. I find it cleans up the code a bit actually.

@mdo
Copy link
Member

mdo commented Mar 18, 2018

Yeah, it doesn't hurt anything having it, but it does apparently need documenting.

@kevinruscoe
Copy link
Contributor

kevinruscoe commented Mar 19, 2018

Hmm, at the moment there's no dedicated place in the documentation for the sass mixins. They are mentioned a couple of times but under their section (i.e. grid and float).

I think we would have to add a root level doc for the mixins because I'm not sure it fits anywhere else.

@MartijnCuppens
Copy link
Member Author

I'm closing this.
Discussion about mixins documentation here: #25977
Once we have an overview of all the mixins, we can figure out which mixins need to be deprecated in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants