Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abbr[title] still has border-bottom on v4-dev #20908

Closed
davidstosik opened this issue Oct 16, 2016 · 1 comment
Closed

abbr[title] still has border-bottom on v4-dev #20908

davidstosik opened this issue Oct 16, 2016 · 1 comment

Comments

@davidstosik
Copy link

Hello,

I wanted to comment on #16574, but it is closed and I can't reopen it, so I was not sure that would notify anyone. Sorry in advance if creating a new issue was bad.

The problem (abbr[title] should not have border-bottom) is still here on v4-dev. I get underline and dotted border-bottom:

image

(Screenshot was taken on Chrome v53 for Mac.)
Here is a JSBin too.

_normalize.scss:112

//
// 1. Remove the bottom border in Firefox 39-.
// 2. Add the correct text decoration in Chrome, Edge, IE, Opera, and Safari.
//

abbr[title] {
  border-bottom: none; // 1
  text-decoration: underline; // 2
  text-decoration: underline dotted; // 2
}

_reboot.scss:114

// Abbreviations and acronyms
abbr[title],
// Add data-* attribute to help out our tooltip plugin, per https://github.com/twbs/bootstrap/issues/5257
abbr[data-original-title] {
  cursor: help;
  border-bottom: 1px dotted $abbr-border-color;
}

In the resulting boostrap.css, the reboot part goes lower than the normalize part, and the border ends up being shown.

@bardiharborow
Copy link
Member

@davidstosik, for future reference, comments on closed issues still notify people.

@mdo mdo added this to the v4.0.0-alpha.6 milestone Nov 29, 2016
mdo added a commit that referenced this issue Nov 29, 2016
Remove the border-bottom from abbr elements since that's covered with an underline in Normalize.css. Updates the docs to match and tweaks some code comments, too.
mdo added a commit that referenced this issue Nov 29, 2016
Remove the border-bottom from abbr elements since that's covered with an underline in Normalize.css. Updates the docs to match and tweaks some code comments, too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants