Skip to content

Commit

Permalink
Remove dialog from the HTML5 shim style (#26269)
Browse files Browse the repository at this point in the history
`<dialog>`, in browsers that support it, has user agent styles of `dialog { display:block; ...} dialog:not([open]) { display:none; }`
by forcing it to `display:block` in the shim, the dialog is shown even when closed. There's no clean way to shim this for non-supporting browsers,
but arguably these browsers would have further problems with pure `<dialog>` usage anyway, and it's up to authors to then use different elements/shims.
  • Loading branch information
patrickhlauke authored Apr 15, 2018
1 parent 871e083 commit e000933
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scss/_reboot.scss
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ html {

// stylelint-disable selector-list-comma-newline-after
// Shim for "new" HTML5 structural elements to display correctly (IE10, older browsers)
article, aside, dialog, figcaption, figure, footer, header, hgroup, main, nav, section {
article, aside, figcaption, figure, footer, header, hgroup, main, nav, section {
display: block;
}
// stylelint-enable selector-list-comma-newline-after
Expand Down

0 comments on commit e000933

Please sign in to comment.