Skip to content

Commit

Permalink
Specify host 0.0.0.0 for Jekyll (#24974)
Browse files Browse the repository at this point in the history 
Allows for remote connections on same network (as Jekyll now seems to default to 127.0.0.1 which means it does not react to incoming external requests)
  • Loading branch information
@patrickhlauke
patrickhlauke authored Dec 11, 2017
1 parent a2a4e63 commit a7e64c8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions _config.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ permalink: pretty
# Server
source: "."
destination: ./_gh_pages
host: 0.0.0.0
port: 9001
baseurl: ""
url: "https://getbootstrap.com"
Expand Down

3 comments on commit a7e64c8

@MikeyBeLike
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickhlauke @XhmikosR btw, this breaks service worker development. As 0.0.0.0 isn't considered a secure domain. Would it be possible to rewrite this back to localhost/127.0.0.1?

For remote connections on same network, can't you just use internal ip & port Jekyll uses? INTERNAL_IP:9001

@XhmikosR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lyricalz: Did you try npm run docs-github && npm run docs-github-serve?

@MikeyBeLike
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XhmikosR okay cool that worked fine

Please sign in to comment.