Skip to content

Commit

Permalink
Fixes #10903 and #10457: IE8-9 don't support events on elements witho…
Browse files Browse the repository at this point in the history
…ut background-color, so we have to hack it
  • Loading branch information
mdo committed Oct 20, 2013
1 parent 32468b0 commit 6a93a6b
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
4 changes: 3 additions & 1 deletion dist/css/bootstrap.css
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,7 @@ address {
}

code,
kdb,
kbd,
pre,
samp {
font-family: Monaco, Menlo, Consolas, "Courier New", monospace;
Expand Down Expand Up @@ -6439,6 +6439,8 @@ button.close {
margin: 1px;
text-indent: -999px;
cursor: pointer;
background-color: #000 \9;
background-color: rgba(0, 0, 0, 0);
border: 1px solid #ffffff;
border-radius: 10px;
}
Expand Down
2 changes: 1 addition & 1 deletion dist/css/bootstrap.min.css

Large diffs are not rendered by default.

11 changes: 11 additions & 0 deletions less/carousel.less
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,17 @@
border: 1px solid @carousel-indicator-border-color;
border-radius: 10px;
cursor: pointer;

// IE8-9 hack for event handling
//
// Internet Explorer 8-9 does not support clicks on elements without a set
// `background-color`. We cannot use `filter` since that's not viewed as a
// background color by the browser. Thus, a hack is needed.
//
// For IE8, we set solid black as it doesn't support `rgba()`. For IE9, we
// set alpha transparency for the best results possible.
background-color: #000 \9; // IE8
background-color: rgba(0,0,0,0); // IE9
}
.active {
margin: 0;
Expand Down

0 comments on commit 6a93a6b

Please sign in to comment.