Skip to content

Commit

Permalink
fix tab fade out (#27533)
Browse files Browse the repository at this point in the history
  • Loading branch information
MartijnCuppens authored and Johann-S committed Oct 29, 2018
1 parent ffc8d50 commit 45610a0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion js/src/tab.js
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ class Tab {
const transitionDuration = Util.getTransitionDurationFromElement(active)

$(active)
.removeClass(ClassName.SHOW)
.one(Util.TRANSITION_END, complete)
.emulateTransitionEnd(transitionDuration)
} else {
Expand All @@ -171,7 +172,7 @@ class Tab {

_transitionComplete(element, active, callback) {
if (active) {
$(active).removeClass(`${ClassName.SHOW} ${ClassName.ACTIVE}`)
$(active).removeClass(ClassName.ACTIVE)

const dropdownChild = $(active.parentNode).find(
Selector.DROPDOWN_ACTIVE_CHILD
Expand Down

0 comments on commit 45610a0

Please sign in to comment.