Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relocate where diagnostics are uploaded #19

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

bfattori
Copy link

Diagnostics would only get uploaded with exit code 0 or 3. This resolves it.
Also TypeError is not a decendant class of Error so you'll never get a stack trace.

Diagnostics would only get uploaded with exit code 0 or 3. This resolves it.
Also TypeError is not a decendant class of Error so you'll never get a stack trace.
@tvcsantos tvcsantos changed the title fix: Relocate where diagnostics are uploaded fix: relocate where diagnostics are uploaded Nov 24, 2024
@tvcsantos
Copy link
Owner

Sorry for the delay. Thanks for the PR, nice catch! 👍

@tvcsantos tvcsantos merged commit b25b75f into tvcsantos:main Nov 24, 2024
@tvcsantos
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants