Skip to content

Commit

Permalink
fix: failing clang-asan/llvm-cov tests (getsentry#965)
Browse files Browse the repository at this point in the history
* Update Python test dependencies
* Update clang on Linux to 15.0.7
* Adapt mmap_rnd_bit according to actions/runner-images#9513
  • Loading branch information
supervacuus authored Mar 15, 2024
1 parent 8f26229 commit e812e7c
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 9 deletions.
13 changes: 9 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,14 @@ jobs:
# RUN_ANALYZER: gcc
- name: Linux (clang + asan + llvm-cov)
os: ubuntu-22.04
CC: clang-14
CXX: clang++-14
CC: clang-15
CXX: clang++-15
ERROR_ON_WARNINGS: 1
RUN_ANALYZER: asan,llvm-cov
- name: Linux (clang + kcov)
os: ubuntu-22.04
CC: clang-14
CXX: clang++-14
CC: clang-15
CXX: clang++-15
ERROR_ON_WARNINGS: 1
RUN_ANALYZER: kcov
- name: Linux (gcc + code-checker + valgrind)
Expand Down Expand Up @@ -137,6 +137,11 @@ jobs:
sudo apt update
sudo apt install cmake gcc-7-multilib g++-7-multilib zlib1g-dev:i386 libssl-dev:i386 libcurl4-openssl-dev:i386
# https://github.com/actions/runner-images/issues/9491
- name: Decrease vm.mmap_rnd_bit to prevent ASLR ASAN issues
if: ${{ runner.os == 'Linux' && contains(env['RUN_ANALYZER'], 'asan') }}
run: sudo sysctl vm.mmap_rnd_bits=28

- name: Installing CodeChecker
if: ${{ contains(env['RUN_ANALYZER'], 'code-checker') }}
run: sudo snap install codechecker --classic
Expand Down
5 changes: 4 additions & 1 deletion tests/assertions.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@ def assert_meta(
"user": {"id": 42, "username": "some_name"},
"transaction": transaction,
"tags": {"expected-tag": "some value"},
"extra": {"extra stuff": "some value", "…unicode key…": "őá…–🤮🚀¿ 한글 테스트"},
"extra": {
"extra stuff": "some value",
"…unicode key…": "őá…–🤮🚀¿ 한글 테스트",
},
}
expected_sdk = {
"name": "sentry.native",
Expand Down
8 changes: 4 additions & 4 deletions tests/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
black==23.3.0
pytest==7.4.0
pytest-httpserver==1.0.8
msgpack==1.0.5
black==24.2.0
pytest==8.0.1
pytest-httpserver==1.0.10
msgpack==1.0.8

0 comments on commit e812e7c

Please sign in to comment.