Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dialog): uses n as CSS vars prefix. #1878

Merged
merged 3 commits into from
Dec 19, 2021
Merged

Conversation

doom-9-zz
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Dec 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/CvDm3Crc1PKSHaYb1SxBBFsiBqsF
✅ Preview: https://naive-ui-git-fork-doom-9-css3-tusimple.vercel.app

@Sepush
Copy link
Collaborator

Sepush commented Dec 17, 2021

you should update the test case

@doom-9-zz
Copy link
Contributor Author

Done, thank you

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #1878 (0814408) into main (9d71ed4) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0814408 differs from pull request most recent head 2ab897f. Consider uploading reports for the commit 2ab897f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
+ Coverage   64.61%   64.63%   +0.01%     
==========================================
  Files         890      890              
  Lines       17403    17403              
  Branches     4127     4126       -1     
==========================================
+ Hits        11245    11248       +3     
+ Misses       5379     5375       -4     
- Partials      779      780       +1     
Impacted Files Coverage Δ
src/dialog/src/Dialog.tsx 77.77% <ø> (ø)
src/dialog/src/styles/index.cssr.ts 100.00% <ø> (ø)
src/form/styles/light.ts 100.00% <0.00%> (ø)
src/data-table/src/TableParts/Cell.tsx 100.00% <0.00%> (ø)
src/_utils/composable/use-houdini.ts 66.66% <0.00%> (+26.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83df1c2...2ab897f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants