Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): Fix n-button's style is overwritten when using other style library #1820

Merged
merged 3 commits into from
Dec 12, 2021
Merged

fix(button): Fix n-button's style is overwritten when using other style library #1820

merged 3 commits into from
Dec 12, 2021

Conversation

XieZongChen
Copy link
Collaborator

@XieZongChen XieZongChen commented Dec 11, 2021

close #1808

@vercel
Copy link

vercel bot commented Dec 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/EMkwthHCeQwjyzSxS8NjC3rDFYcH
✅ Preview: https://naive-ui-git-fork-amadeus711-fix-nbutton-color-8f185c-tusimple.vercel.app

@XieZongChen XieZongChen changed the title fix(button): Fix n-button's color is overwritten when using other sty… fix(button): Fix n-button's color is overwritten when using other style library Dec 11, 2021
@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #1820 (7396a6c) into main (664a08d) will decrease coverage by 0.01%.
The diff coverage is 23.52%.

❗ Current head 7396a6c differs from pull request most recent head da957f0. Consider uploading reports for the commit da957f0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1820      +/-   ##
==========================================
- Coverage   64.80%   64.79%   -0.02%     
==========================================
  Files         890      890              
  Lines       17302    17297       -5     
  Branches     4100     4098       -2     
==========================================
- Hits        11213    11208       -5     
+ Misses       5314     5313       -1     
- Partials      775      776       +1     
Impacted Files Coverage Δ
src/button/src/styles/button.cssr.ts 80.00% <ø> (ø)
src/button/src/Button.tsx 64.86% <23.52%> (ø)
src/popselect/src/PopselectPanel.tsx 31.57% <0.00%> (-2.85%) ⬇️
src/cascader/src/Cascader.tsx 39.20% <0.00%> (-0.12%) ⬇️
src/cascader/styles/dark.ts 100.00% <0.00%> (ø)
src/cascader/styles/light.ts 100.00% <0.00%> (ø)
src/popselect/src/Popselect.tsx 90.00% <0.00%> (ø)
src/cascader/src/CascaderMenu.tsx 54.54% <0.00%> (ø)
src/_internal/selection/src/Selection.tsx 41.46% <0.00%> (ø)
src/_internal/selection/src/styles/index.cssr.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0989eee...da957f0. Read the comment docs.

@XieZongChen XieZongChen changed the title fix(button): Fix n-button's color is overwritten when using other style library fix(button): Fix n-button's style is overwritten when using other style library Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CSS] class 权重过低,被 tailwindcss3 Preflight 样式覆盖
2 participants