Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table can selete when loading #1815

Merged
merged 3 commits into from
Dec 12, 2021
Merged

fix: table can selete when loading #1815

merged 3 commits into from
Dec 12, 2021

Conversation

Talljack
Copy link
Contributor

close #1812

@vercel
Copy link

vercel bot commented Dec 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/5J9ZM7ewgai16mCfPq2uysn4x3vp
✅ Preview: https://naive-ui-git-fork-talljack-1812-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #1815 (d6f47e7) into main (577eda4) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head d6f47e7 differs from pull request most recent head 00254fb. Consider uploading reports for the commit 00254fb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1815      +/-   ##
==========================================
- Coverage   64.81%   64.78%   -0.03%     
==========================================
  Files         890      890              
  Lines       17307    17299       -8     
  Branches     4103     4100       -3     
==========================================
- Hits        11217    11208       -9     
+ Misses       5315     5314       -1     
- Partials      775      777       +2     
Impacted Files Coverage Δ
src/data-table/src/use-check.ts 72.58% <0.00%> (-2.42%) ⬇️
src/popselect/src/PopselectPanel.tsx 31.57% <0.00%> (-2.85%) ⬇️
src/avatar/src/Avatar.tsx 78.94% <0.00%> (-0.37%) ⬇️
src/image/src/Image.tsx 88.00% <0.00%> (-0.24%) ⬇️
src/button/src/Button.tsx 64.86% <0.00%> (-0.19%) ⬇️
src/page-header/src/PageHeader.tsx 94.44% <0.00%> (-0.16%) ⬇️
src/cascader/src/Cascader.tsx 39.20% <0.00%> (-0.12%) ⬇️
src/cascader/styles/dark.ts 100.00% <0.00%> (ø)
src/cascader/styles/light.ts 100.00% <0.00%> (ø)
src/popselect/src/Popselect.tsx 90.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a0608...00254fb. Read the comment docs.

CHANGELOG.zh-CN.md Outdated Show resolved Hide resolved
@@ -104,7 +106,7 @@ export function useCheck (
}
function doCheckAll (checkWholeTable: boolean = false): void {
const { value: column } = selectionColumnRef
if (!column) return
if (!column || props.loading) return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

往上提一下,越早拦住越好

@@ -123,7 +125,7 @@ export function useCheck (
}
function doUncheckAll (checkWholeTable: boolean = false): void {
const { value: column } = selectionColumnRef
if (!column) return
if (!column || props.loading) return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

往上提一下,越早拦住越好

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table loading状态还能选择
3 participants