-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: table can selete when loading #1815
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tusimple/naive-ui/5J9ZM7ewgai16mCfPq2uysn4x3vp |
Codecov Report
@@ Coverage Diff @@
## main #1815 +/- ##
==========================================
- Coverage 64.81% 64.78% -0.03%
==========================================
Files 890 890
Lines 17307 17299 -8
Branches 4103 4100 -3
==========================================
- Hits 11217 11208 -9
+ Misses 5315 5314 -1
- Partials 775 777 +2
Continue to review full report at Codecov.
|
@@ -104,7 +106,7 @@ export function useCheck ( | |||
} | |||
function doCheckAll (checkWholeTable: boolean = false): void { | |||
const { value: column } = selectionColumnRef | |||
if (!column) return | |||
if (!column || props.loading) return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
往上提一下,越早拦住越好
@@ -123,7 +125,7 @@ export function useCheck ( | |||
} | |||
function doUncheckAll (checkWholeTable: boolean = false): void { | |||
const { value: column } = selectionColumnRef | |||
if (!column) return | |||
if (!column || props.loading) return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
往上提一下,越早拦住越好
close #1812