Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(time-picker): blur event not trigger #1505

Merged
merged 4 commits into from
Nov 8, 2021
Merged

Conversation

Volankey
Copy link
Collaborator

@Volankey Volankey commented Nov 2, 2021

closes: #1499

@vercel
Copy link

vercel bot commented Nov 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/2CgxiUSCWi178i1atpaLnuXoTZyc
✅ Preview: https://naive-ui-git-fork-volankey-1499-tusimple.vercel.app

CHANGELOG.zh-CN.md Outdated Show resolved Hide resolved
@XieZongChen
Copy link
Collaborator

XieZongChen commented Nov 2, 2021

CI 问题修复了,请 rebase + push -f

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #1505 (bef4052) into main (ce90d25) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

❗ Current head bef4052 differs from pull request most recent head ee3c81c. Consider uploading reports for the commit ee3c81c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1505      +/-   ##
==========================================
- Coverage   63.92%   63.75%   -0.18%     
==========================================
  Files         884      880       -4     
  Lines       17108    17090      -18     
  Branches     4043     4042       -1     
==========================================
- Hits        10937    10895      -42     
- Misses       5434     5463      +29     
+ Partials      737      732       -5     
Impacted Files Coverage Δ
src/time-picker/src/TimePicker.tsx 53.25% <0.00%> (-0.59%) ⬇️
src/input/src/InputGroupLabel.tsx 43.75% <0.00%> (-50.00%) ⬇️
src/tree/src/TreeNodeContent.tsx 75.00% <0.00%> (-15.00%) ⬇️
src/tree/src/Tree.tsx 28.11% <0.00%> (-2.96%) ⬇️
src/tree/src/TreeNode.tsx 50.57% <0.00%> (-1.15%) ⬇️
src/upload/src/Upload.tsx 74.52% <0.00%> (-0.17%) ⬇️
src/locales/index.ts 100.00% <0.00%> (ø)
src/locales/date/deDE.ts
src/locales/date/nbNO.ts
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d969580...ee3c81c. Read the comment docs.

Comment on lines 13 to 17
- Fix `n-time-picker` not trigger blur event when the panel is closed by ok button, closes [#1499](https://github.com/TuSimple/naive-ui/issues/1499).

### Fixes

- `n-time-picker` not trigger blur event when the panel is closed by ok button, closes [#1499](https://github.com/TuSimple/naive-ui/issues/1499).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 13 to 16
- 修复 `n-time-picker` 当选择面板通过确认按钮关闭时不会触发 blur 事件, closes [#1499](https://github.com/TuSimple/naive-ui/issues/1499)

### Fixes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -413,6 +413,8 @@ export default defineComponent({
returnFocus: false
})
}
} else {
doBlur(e)
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

搞个测试吧,把 issue 的 case 模拟一下

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTimePicker with action=confirm: blur event does not fire if you click the ok button then focus another field
5 participants