-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(time-picker): blur event not trigger #1505
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tusimple/naive-ui/2CgxiUSCWi178i1atpaLnuXoTZyc |
CI 问题修复了,请 rebase + push -f |
Codecov Report
@@ Coverage Diff @@
## main #1505 +/- ##
==========================================
- Coverage 63.92% 63.75% -0.18%
==========================================
Files 884 880 -4
Lines 17108 17090 -18
Branches 4043 4042 -1
==========================================
- Hits 10937 10895 -42
- Misses 5434 5463 +29
+ Partials 737 732 -5
Continue to review full report at Codecov.
|
CHANGELOG.en-US.md
Outdated
- Fix `n-time-picker` not trigger blur event when the panel is closed by ok button, closes [#1499](https://github.com/TuSimple/naive-ui/issues/1499). | ||
|
||
### Fixes | ||
|
||
- `n-time-picker` not trigger blur event when the panel is closed by ok button, closes [#1499](https://github.com/TuSimple/naive-ui/issues/1499). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
CHANGELOG.zh-CN.md
Outdated
- 修复 `n-time-picker` 当选择面板通过确认按钮关闭时不会触发 blur 事件, closes [#1499](https://github.com/TuSimple/naive-ui/issues/1499) | ||
|
||
### Fixes | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
@@ -413,6 +413,8 @@ export default defineComponent({ | |||
returnFocus: false | |||
}) | |||
} | |||
} else { | |||
doBlur(e) | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
搞个测试吧,把 issue 的 case 模拟一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok 了
closes: #1499