Fix(form): Collpsed in FormItemGi does not work #1166

LYErin · 2021-09-13T10:12:12Z

vercel · 2021-09-13T10:12:17Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/7S3wkCSnsDp9RJfxzVfUesQ8ovAG
✅ Preview: https://naive-ui-git-fork-lyerin-fix-collpsed-in-formitemgi-tusimple.vercel.app

codecov · 2021-09-13T10:17:56Z

Codecov Report

Merging #1166 (afc0b1b) into main (78449db) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
- Coverage   49.77%   49.77%   -0.01%     
==========================================
  Files         514      514              
  Lines       12718    12720       +2     
  Branches     3601     3601              
==========================================
  Hits         6331     6331              
- Misses       5298     5300       +2     
  Partials     1089     1089

Impacted Files	Coverage Δ
src/form/src/FormItemGridItem.ts	`11.76% <0.00%> (-1.57%)`	⬇️
src/grid/src/GridItem.tsx	`77.77% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78449db...afc0b1b. Read the comment docs.

src/grid/src/GridItem.tsx

Volankey · 2021-09-13T11:19:52Z

src/form/src/FormItemGridItem.ts

-    return h(NGridItem, keep(this.$props, gridItemPropKeys), {
+    const self = getCurrentInstance()
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    const gridItemProps = self!.vnode.props as GridItemVNodeProps


这几行得写到 setup里面么

写在这个位置看起来没啥毛病。

不过也是有问题的，就是说把 formItemProps 也传给 gridItemProps 了，得想办法改一下。

self!.vnode.props 打印出来是不包含formItemProps的, 只有GridItemVNodeProps定义的几个类型值

07akioni · 2021-09-15T18:18:25Z

@LYErin 看一看修正之后的实现 c1e2946

主要是 FormItemGi 的 render 开始那两行

unknown added 2 commits September 13, 2021 18:04

fix(n-form): collapse does not work in FormItemGi

51105f9

fix(n-form): add commit log

afc0b1b

vercel bot deployed to Preview September 13, 2021 10:12 View deployment

Volankey reviewed Sep 13, 2021

View reviewed changes

07akioni merged commit c11edb2 into tusen-ai:main Sep 15, 2021

LYErin deleted the fix-collpsed-in-formItemGi branch September 20, 2021 01:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix(form): Collpsed in FormItemGi does not work #1166

Fix(form): Collpsed in FormItemGi does not work #1166

LYErin commented Sep 13, 2021

vercel bot commented Sep 13, 2021 •

edited

Loading

codecov bot commented Sep 13, 2021

Volankey Sep 13, 2021

07akioni Sep 13, 2021

LYErin Sep 14, 2021

07akioni commented Sep 15, 2021 •

edited

Loading

Fix(form): Collpsed in FormItemGi does not work #1166

Fix(form): Collpsed in FormItemGi does not work #1166

Conversation

LYErin commented Sep 13, 2021

vercel bot commented Sep 13, 2021 • edited Loading

codecov bot commented Sep 13, 2021

Codecov Report

Volankey Sep 13, 2021

Choose a reason for hiding this comment

07akioni Sep 13, 2021

Choose a reason for hiding this comment

LYErin Sep 14, 2021

Choose a reason for hiding this comment

07akioni commented Sep 15, 2021 • edited Loading

vercel bot commented Sep 13, 2021 •

edited

Loading

07akioni commented Sep 15, 2021 •

edited

Loading