Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collapse): add 'header-extra' slot #1064

Merged
merged 7 commits into from
Sep 4, 2021

Conversation

LYErin
Copy link
Contributor

@LYErin LYErin commented Sep 3, 2021

close #1046

@vercel
Copy link

vercel bot commented Sep 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/645zkcUxnnCUYeKAnRuuPtuX72iy
✅ Preview: https://naive-ui-git-fork-lyerin-feat-add-collapse-suffix-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #1064 (422e443) into main (286e29d) will decrease coverage by 0.09%.
The diff coverage is 75.00%.

❗ Current head 422e443 differs from pull request most recent head cb64f3c. Consider uploading reports for the commit cb64f3c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
- Coverage   47.33%   47.23%   -0.10%     
==========================================
  Files         511      511              
  Lines       12638    12626      -12     
  Branches     3563     3555       -8     
==========================================
- Hits         5982     5964      -18     
- Misses       5639     5643       +4     
- Partials     1017     1019       +2     
Impacted Files Coverage Δ
src/collapse/src/CollapseItem.tsx 80.00% <75.00%> (-1.58%) ⬇️
src/steps/src/Step.tsx 73.80% <0.00%> (-14.29%) ⬇️
src/_utils/vue/flatten.ts 56.25% <0.00%> (-4.87%) ⬇️
src/cascader/src/Cascader.tsx 17.74% <0.00%> (-4.10%) ⬇️
src/space/src/Space.tsx 100.00% <0.00%> (ø)
src/message/src/Message.tsx 70.58% <0.00%> (ø)
src/upload/src/interface.ts 100.00% <0.00%> (ø)
src/cascader/src/interface.ts 100.00% <0.00%> (ø)
src/code/src/styles/index.cssr.ts 100.00% <0.00%> (ø)
src/descriptions/src/Descriptions.tsx 87.03% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286e29d...cb64f3c. Read the comment docs.

display: flex;
align-items: center;
font-size: var(--font-size);
font-weight: 400;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是从那里继承的,只在 header main 作用的话应该不会影响这里吧

Copy link
Contributor Author

@LYErin LYErin Sep 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那就改成固定font-size: 14?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我说的是 font-weight

@07akioni 07akioni merged commit 98ccbab into tusen-ai:main Sep 4, 2021
@LYErin LYErin deleted the feat-add-collapse-suffix branch November 4, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can Collapse component add suffix slot ?
2 participants