Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindings/java: Enhance exception handling logic #642

Closed
wants to merge 2 commits into from
Closed

bindings/java: Enhance exception handling logic #642

wants to merge 2 commits into from

Conversation

seonWKim
Copy link
Contributor

@seonWKim seonWKim commented Jan 10, 2025 •
edited
Loading

Purpose of this PR

  • Enhance exception handling logic
    • When exceptions has to be thrown from Rust to Java, let's just return the error message directly.
    • Removes JNI call to get error message using Java_org_github_tursodatabase_core_LimboDB_getErrorMessageUtf8
  • Add throwJavaException to assure that the exception throwing logic works corretly

Reference

#615

@seonWKim seonWKim closed this Jan 10, 2025
@seonWKim seonWKim reopened this Jan 10, 2025
@penberg penberg changed the title Enhance exception handling logic bindings/java: Enhance exception handling logic Jan 10, 2025
@penberg penberg closed this in 93e4b8d Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seonWKim