Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinguish balance and balance_non_root #634

Merged
merged 1 commit into from
Jan 9, 2025
Merged

distinguish balance and balance_non_root #634

merged 1 commit into from
Jan 9, 2025

Conversation

pereman2
Copy link
Collaborator

@pereman2 pereman2 commented Jan 8, 2025

balance_non_root should be as close as possible to balance_non_root in SQLite. This commits extract balance_non_root from balance and renames balance_leaf to balance as it enables future work on a complete balance_non_root procedure.

`balance_non_root` should be as close as possible to `balance_non_root`
in SQLite. This commits extract `balance_non_root` from `balance` and
renames `balance_leaf` to `balance` as it enables future work on a
complete `balance_non_root` procedure.
@krishvishal
Copy link
Contributor

I like this change. Because now we can just call balance which then calls the respective functions based on if its root or non_root.

Would it make sense to add a BalanceRoot variant to the WriteState enum? IMO this makes sense to add because balancing root page is a distinct operation with some edge cases and this would also help with DST.

@penberg penberg merged commit 2bf7e31 into main Jan 9, 2025
36 checks passed
@penberg penberg deleted the balance_non_root branch January 9, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants