Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizer bugfixes #630

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Optimizer bugfixes #630

merged 3 commits into from
Jan 8, 2025

Conversation

jussisaurio
Copy link
Collaborator

Closes #629

  • Fix bug with column being considered rowid alias based on 'primary_key' (non INTEGER pks are not rowid aliases)
  • fix logic bug in check_index_scan() that swapped lhs/rhs but not the comparison op
  • Rename eliminate_between to rewrite_exprs and add true/false->1/0 case there

@penberg penberg closed this in 0ef4def Jan 8, 2025
@penberg penberg merged commit 0ef4def into main Jan 8, 2025
36 checks passed
@penberg penberg deleted the optimizer-fixes branch January 8, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

op Id(Id("TRUE")) not implemented
2 participants
@jussisaurio @penberg