-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use covering indexes #592
base: main
Are you sure you want to change the base?
Conversation
What do P1, P2, P3, P4, and P5 represent? |
a850b24
to
0caeb2b
Compare
the current CI error is because |
0caeb2b
to
8683df7
Compare
Hi, I've read this and I think it's a great effort! Mainly I would like to see a bit of a different approach... here are some very raw thoughts, and not all of them might make sense on the implementation level with our current code, but here goes anyway:
Also sorry about the million merge conflicts... |
@jussisaurio Thank you for your comment, I think it is very valuable.I made the following changes based on your comment
If this modification meets your expectations, I will deal with the code conflicts later. |
919adbf
to
2d4517a
Compare
2d4517a
to
3637a82
Compare
issue: #364
this pr enables limbo to detect whether the relevant columns in the plan can be index covered while the index is hitting, thereby reducing the need to return to the table.
TODO:
related_columns
(I refer to other optimization rules but cannot find relevant tests. Do you have any suggestions on this?)column
in explainbefore: