Implement json_error_position #564
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonhmai
reviewed
Dec 28, 2024
| )), | ||
| }, | ||
| OwnedValue::Null => Ok(OwnedValue::Null), | ||
| _ => Ok(OwnedValue::Integer(0)), |
There was a problem hiding this comment.
how will this handle OwnedValue::Agg and OwnedValue:Record here?
There was a problem hiding this comment.
From my testing, sqlite just returns 0 for anything not text (or blob that could be interpreted as text). I stuck to the same plan, but perhaps using unreachable! would be better for these other, unsupported types. That's how json_array handles it.
sqlite> SELECT json_error_position(avg(price)) FROM products;
0
sonhmai
reviewed
Dec 28, 2024
petersooley
force-pushed
the
json-error-position
branch
from
72023e8 to
c234e14
Compare
petersooley
force-pushed
the
json-error-position
branch
from
c234e14 to
b2086e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Furthering work for JSON compatibility as described in #127, this change adds support for the
json_error_positionfunction used to find the error in invalid JSON values.