Explain macro to handle metadata for descibing the vdbe instructions. #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes p1, p2 and p3 mapped from a match table based on attribute tags added to the enum variant fields. A description attribute that is pulled from the enum variant and builds out a const array for the .opcodes command that is generated from the descriptions.
|
This pull request has been marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes p1, p2 and p3 mapped from a match table based on attribute tags added to the enum variant fields.
A description attribute that is pulled from the enum variant and builds out a const array for the .opcodes command that is generated from the descriptions.
I just saw that #528 was overlapping this one. So I thought I would at least get this up to discuss and try to mitigate as many merge conflicts as possible.
I have more coming for this, but I had to stash the p4, p5 pieces so I could get this up before there was more overlap.