-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL with named anchor not localising #372
Comments
turquoiseowl
added a commit
that referenced
this issue
Jul 7, 2018
turquoiseowl
added a commit
that referenced
this issue
Jul 7, 2018
Yes, it was a bug. Hopefully fixed now. Let me know if not. New release 2.1.13 just published with the fix. |
Ah great stuff. Yeah that sorted it out. Glad I found a bug, I really thought I'd missed something. |
Good to know, thanks. |
turquoiseowl
added a commit
that referenced
this issue
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've hit a snag thats got me stumped and I'm not sure if its a bug or just some limitation that I'm unaware of.
My issue is that I've made a html helper using MergeAttribute to generate a menu eg:
link.MergeAttribute("href", menuItem.URL);
It works as expected unless the URL includes a named anchor.
So '/testpage' correctly becomes '/en/testpage' but '/testpage#foo' just gets rendered as '/testpage#foo'
Could it be that the URL with the anchor is failing the regex in EarlyUrlLocalizer.cs? I'm hopeless at regex so I really can't tell (It's a dark art I've never managed to get my head around) or could something else be tripping it up?
The text was updated successfully, but these errors were encountered: