[pull] master from atom:master #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Information on required Visual Studio versions and Python versions were out of date, considering that we use newer `node-gyp` now.
Python 3 will be supported on Windows when atom/atom#20856 or similar gets merged into the atom repository.
This should be a recommended way of getting build tools set up. It works really well, and is much easier than a manual install of Visual Studio/C++ tools/Python 2. It sets them all up for you. I personally wouldn't recommend any other way to someone I knew. Co-authored-by: Amin Yahyaabadi <[email protected]>
Visual Studio 2015, 2017 and 2019 are supported. Windows 8 SDK or Windows 10 SDK are supported. Clarified windows-build-tools install instructions. The latest windows-build-tools will be fine for the foreseeable future (Even when they default to Visual Studio 2019 some time soon.)
Update install instructions for Windows.
This is now a dependency "7zip-bin" in `scripts/package.json`. The script doesn't look for 7-Zip on the system anymore, so it wouldn't be used even if installed.
This should be the first option. It is recommended by node-gyp and Microsoft. It is either officially or unofficially developed and maintained by Microsoft themselves.
- Suggest installing windows-build-tools v4, as v5 can hang and fail to install. - Don't use the `--production` flag to install windows-build-tools; Not installing devDependencies is already implied when installing a package by name.
Building Atom with Visual Studio 2019 causes a few CI tests to fail, so hold off on recommending Visual Studio 2019 for now.
This version of npm includes newer node-gyp, which is better at automatically detecting Python (especially Python 3), and also better at automatically detecting Visual Studio.
Hacking on Atom Core: Update build requirements to be accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )