Add support to query identity settings in App Service > Web App. closes #54 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbruno10
reviewed
Apr 19, 2021
| @@ -88,6 +88,24 @@ func tableAzureAppServiceWebApp(_ context.Context) *plugin.Table { | |||
| Type: proto.ColumnType_BOOL, | |||
| Transform: transform.FromField("SiteProperties.HTTPSOnly"), | |||
| }, | |||
| { | |||
| Name: "identity_type", | |||
There was a problem hiding this comment.
@Paulami30 Since there aren't that many fields here, and identity information is easy to find, would this work if we just had an identity column with the JSON type?
There was a problem hiding this comment.
If we fetch the whole identity column, we do not get the data. That is why I had to fetch the keys from the object.
cbruno10
requested changes
Apr 22, 2021
There was a problem hiding this comment.
@Paulami30 Similar to how we handle the response data format in the azure_firewall table, could we handle it similar to https://github.com/turbot/steampipe-plugin-azure/blob/main/azure/table_azure_firewall.go#L247 and condense the data into an identity column?
Integration test logsLogs |
Subhajit97
reviewed
Apr 30, 2021
Subhajit97
reviewed
Apr 30, 2021
Subhajit97
reviewed
Apr 30, 2021
New Query ExampleList web apps that have managed service identity set to disabledselect
name,
enabled,
region,
identity
from
azure_app_service_web_app
where
identity = '{}'; |
cbruno10
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test logs
Logs