Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing web_application_firewall_configuration details in table azure_application_gateway Closes #765 #770

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Jun 3, 2024

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
> select name, jsonb_pretty(web_application_firewall_configuration) from azure_application_gateway;
+----------+----------------------------------------------------------------------------------------------------------------------------------------------------------+
| name     | jsonb_pretty                                                                                                                                             |
+----------+----------------------------------------------------------------------------------------------------------------------------------------------------------+
| test2223 | <null>                                                                                                                                                   |
| testgw3  | {                                                                                                                                                        |
|          |     "CustomRules": [                                                                                                                                     |
|          |     ],                                                                                                                                                   |
|          |     "ManagedRules": {                                                                                                                                    |
|          |         "exclusions": [                                                                                                                                  |
|          |         ],                                                                                                                                               |
|          |         "managedRuleSets": [                                                                                                                             |
|          |             {                                                                                                                                            |
|          |                 "ruleSetType": "OWASP",                                                                                                                  |
|          |                 "ruleSetVersion": "3.2",                                                                                                                 |
|          |                 "ruleGroupOverrides": [                                                                                                                  |
|          |                 ]                                                                                                                                        |
|          |             }                                                                                                                                            |
|          |         ]                                                                                                                                                |
|          |     },                                                                                                                                                   |
|          |     "HTTPListeners": null,                                                                                                                               |
|          |     "ResourceState": null,                                                                                                                               |
|          |     "PathBasedRules": null,                                                                                                                              |
|          |     "PolicySettings": {                                                                                                                                  |
|          |         "mode": "Detection",                                                                                                                             |
|          |         "state": "Disabled",                                                                                                                             |
|          |         "requestBodyCheck": true,                                                                                                                        |
|          |         "fileUploadLimitInMb": 100,                                                                                                                      |
|          |         "maxRequestBodySizeInKb": 128                                                                                                                    |
|          |     },                                                                                                                                                   |
|          |     "ProvisioningState": "Succeeded",                                                                                                                    |
|          |     "ApplicationGateways": [                                                                                                                             |
|          |         {                                                                                                                                                |
|          |             "id": "/subscriptions/************************************/resourceGroups/turbot_rg/providers/Microsoft.Network/applicationGateways/testgw3" |
|          |         }                                                                                                                                                |
|          |     ]                                                                                                                                                    |
|          | }                                                                                                                                                        |
+----------+----------------------------------------------------------------------------------------------------------------------------------------------------------+

@ParthaI ParthaI requested a review from misraved June 3, 2024 13:08
@ParthaI ParthaI self-assigned this Jun 3, 2024
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthaI could you please take a look at the review comments? Thanks !!

azure/table_azure_application_gateway.go Outdated Show resolved Hide resolved
azure/table_azure_application_gateway.go Outdated Show resolved Hide resolved
@misraved misraved merged commit eb2037c into main Jun 10, 2024
1 check passed
@misraved misraved deleted the issue-765 branch June 10, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing web_application_firewall_configuration details in Steampipe Azure plugin
2 participants