Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update incorrect Column Type for Network Access Fields in azure_application_insight Table. Closes #768 #769

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Update incorrect Column Type for Network Access Fields in azure_application_insight Table. Closes #768 #769

merged 1 commit into from
Jun 6, 2024

Conversation

Priyanka-Chatterjee-2000
Copy link
Contributor

@Priyanka-Chatterjee-2000 Priyanka-Chatterjee-2000 commented May 31, 2024 •
edited
Loading

Results

Results 
When it was json column:-
select public_network_access_for_ingestion,public_network_access_for_query from azure_application_insight
+-------------------------------------+---------------------------------+
| public_network_access_for_ingestion | public_network_access_for_query |
+-------------------------------------+---------------------------------+
| "Enabled"                           | "Enabled"                       |
+-------------------------------------+---------------------------------+

After changing the column type to string:-
select public_network_access_for_ingestion,public_network_access_for_query from azure_application_insight
+-------------------------------------+---------------------------------+
| public_network_access_for_ingestion | public_network_access_for_query |
+-------------------------------------+---------------------------------+
| Enabled                             | Enabled                         |
+-------------------------------------+---------------------------------+

@Priyanka-Chatterjee-2000 Priyanka-Chatterjee-2000 linked an issue May 31, 2024 that may be closed by this pull request
Incorrect Column Type for Network Access Fields in azure_application_insight Table #768
Closed
@Priyanka-Chatterjee-2000 Priyanka-Chatterjee-2000 changed the title Update columns type from json to string. Closes #768 Update incorrect Column Type for Network Access Fields in azure_application_insight Table. Closes #768 Jun 3, 2024
@misraved
Copy link
Contributor

misraved commented Jun 5, 2024

@Priyanka-Chatterjee-2000 could you please add the queries in the PR body reflecting the two columns that have been updated? Thanks!!

@misraved misraved merged commit 09276e2 into main Jun 6, 2024
1 check passed
@misraved misraved deleted the issue#768 branch June 6, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParthaI ParthaI ParthaI approved these changes

Assignees

@Priyanka-Chatterjee-2000 Priyanka-Chatterjee-2000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Column Type for Network Access Fields in azure_application_insight Table
3 participants
@Priyanka-Chatterjee-2000 @misraved @ParthaI