Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the table azure_role_assignment for populating the column value correctly Closes #759 #763

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented May 27, 2024

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
> select
  name,
  principal_id,
  principal_type
from
  azure_role_assignment;
+--------------------------------------+--------------------------------------+------------------+
| name                                 | principal_id                         | principal_type   |
+--------------------------------------+--------------------------------------+------------------+
| b4596e75-b6c9-46b6-8b7d-cce52ac49495 | 92f0bf94-4e47-41ea-bc68-5e97c5a3f9ff | User             |
| 86a52481-d93a-4db1-bd65-0418a21838ed | 7bafb0a2-eee8-48c6-81ec-039836536d96 | Group            |
| 6c21b1b1-bb25-42b1-8b9f-bf4b151eefc3 | 5466f530-deaa-4e3f-82cc-fb9dffb59444 | ServicePrincipal |
| 43b6cbd9-e9d1-48c9-72a0-31de1edc517d | 603d5c10-3a89-4012-a0f8-7027dc91377e | ServicePrincipal |
| 58414e13-5938-897b-11f6-702bbba8d934 | 5137b8d3-8040-421e-b3cd-f30ac06b6636 | User             |
| cd98d652-1ad8-414e-9907-728d59cd8e1a | 85551e49-da13-4ded-aab3-89e41708d57b | User             |
| 7791b5fa-7772-45f1-a1a8-a74e2e1aa68a | 85551e49-da13-4ded-aab3-89e41708d57b | User             |
| 227eac1b-7153-41f0-b4d5-aeb5846be012 | be019a25-c94a-4f56-8494-718beee5041f | ServicePrincipal |
| 2ccabf4e-8b0d-4b6c-87a2-a69beb45f288 | 06fd46b0-a867-49a1-a4f1-f7768465caba | User             |
| 19eb06cf-e7f6-48dc-b429-1219b1a5efab | 09e7a3cd-4fc8-4d55-bb62-aaef76a8b439 | ServicePrincipal |
| 5e784ce2-50c4-417b-b1a0-f337fe2f4120 | 603d5c10-3a89-4012-a0f8-7027dc91377e | ServicePrincipal |
| ffdbc1b7-fd44-4560-7339-1d4888cae4b4 | 4b5954c1-9ba8-4bf7-aaaa-08ffbd0e818c | ServicePrincipal |
| 166571c7-97ce-44fb-9d63-95ec65a3179f | 59f1c908-649f-4b49-927c-9e26a83b443f | User             |
| 7e540c99-96e3-4d0f-9394-9c66f2f744ba | 50d5a67a-44b9-43ed-ae19-0a6b6c229a54 | User             |
| cb3b17b8-0693-4262-a4ac-c0b0788ede1d | 921ad0bf-d82b-4e1c-b454-95a60ed3b12c | User             |
| e616fc9c-c9dd-42b9-b83d-5b2e228df050 | b49ae36f-aa49-4501-852a-fdaf1f10993f | User             |
| 302dd255-20d5-4e21-ff39-0cf87394e7ab | 748180ba-b7f8-4c22-a425-92b4e57eeee6 | ServicePrincipal |
| bed41c28-faad-4982-f9a1-bf660876131f | 8eac489a-1b86-42fe-a635-8a9a595e5ce2 | ServicePrincipal |
| f0ef385f-8fd9-44a7-5150-2a9b0341d118 | e057b134-d9de-4b1a-b7a2-12aa172ad2b8 | ServicePrincipal |

Copy link

@jeffreymp17 jeffreymp17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@jeffreymp17 jeffreymp17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@misraved @ParthaI is there a way to prioritize this?

@ParthaI
Copy link
Contributor Author

ParthaI commented Jun 5, 2024

@jeffreymp17, sorry for the delay. @misraved, could you please prioritize this?

@misraved misraved merged commit ce9820b into main Jun 10, 2024
1 check passed
@misraved misraved deleted the issue-759 branch June 10, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After SDK updated azure_role_assignment is not getting correctly principal_id and principal_type
4 participants