Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure SDK version #747

Merged
merged 14 commits into from
May 13, 2024
Merged

Update Azure SDK version #747

merged 14 commits into from
May 13, 2024

Conversation

bigdatasourav
Copy link
Contributor

@bigdatasourav bigdatasourav commented Apr 19, 2024

  • Update SDK to v68(latest)
  • Add authentication method using azidentity and resourcemanager (GetNewSessionUpdated function)
  • Add cache to the GetNewSessionUpdated function
  • Keep the existing SPC requirement
  • Keep the existing GetNewSession function
  • Update the tables which are failing due to SDK update to use the GetNewSessionUpdated
  • Manually check the failed tables after the pkg update and list the ones with breaking changes
    • azure_kubernetes_service_version (Breaking change but not used by any Azure Mod)
      Current columns -
   > .inspect azure_kubernetes_service_version
+----------------------+---------+-------------------------------------------------------------------------------+
| column               | type    | description                                                                   |
+----------------------+---------+-------------------------------------------------------------------------------+
| _ctx                 | jsonb   | Steampipe context in JSON form, e.g. connection_name.                         |
| akas                 | jsonb   | Array of globally unique identifier strings (also known as) for the resource. |
| cloud_environment    | text    | The Azure Cloud Environment.                                                  |
| default              | boolean | Installed by default if version is not specified.                             |
| id                   | text    | ID of the orchestrator version profile list result.                           |
| is_preview           | boolean | Whether Kubernetes version is currently in preview.                           |
| location             | text    | The Azure region/location in which the resource is located.                   |
| name                 | text    | Name of the orchestrator version profile list result.                         |
| orchestrator_type    | text    | The orchestrator type.                                                        |
| orchestrator_version | text    | Orchestrator version (major, minor, patch).                                   |
| resource_type        | text    | Whether Kubernetes version is currently in preview.                           |
| subscription_id      | text    | The Azure Subscription ID in which the resource is located.                   |
| title                | text    | Title of the resource.                                                        |
| type                 | text    | Type of the orchestrator version profile list result.                         |
| upgrades             | jsonb   | The list of available upgrade versions.                                       |
+----------------------+---------+-------------------------------------------------------------------------------+

Updated Column Set -

> .inspect azure_kubernetes_service_version
+-------------------+---------+-------------------------------------------------------------+
| column            | type    | description                                                 |
+-------------------+---------+-------------------------------------------------------------+
| _ctx              | jsonb   | Steampipe context in JSON form, e.g. connection_name.       |
| capabilities      | jsonb   | Capabilities on this Kubernetes version.                    |
| cloud_environment | text    | The Azure Cloud Environment.                                |
| is_preview        | boolean | Whether Kubernetes version is currently in preview.         |
| location          | text    | The Azure region/location in which the resource is located. |
| patch_versions    | jsonb   | Patch versions of Kubernetes release.                       |
| subscription_id   | text    | The Azure Subscription ID in which the resource is located. |
| title             | text    | Title of the resource.                                      |
| version           | text    | The major.minor version of Kubernetes release.              |
+-------------------+---------+-------------------------------------------------------------+
  • Update the deprecated pkgs for all the tables
  • Run integration test. - Pending

@bigdatasourav bigdatasourav self-assigned this Apr 19, 2024
@bigdatasourav bigdatasourav marked this pull request as draft April 19, 2024 08:16
@misraved misraved changed the title Update SDK version Update Azure SDK version Apr 23, 2024
@bigdatasourav bigdatasourav requested a review from misraved April 28, 2024 15:38
@bigdatasourav bigdatasourav marked this pull request as ready for review April 28, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants