Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table azure_databricks_workspace. Closes #691. #692

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Add table azure_databricks_workspace. Closes #691. #692

merged 3 commits into from
Nov 2, 2023

Conversation

madhushreeray30
Copy link
Contributor

Integration test logs

Logs 
Add passing integration test logs here

Example query results

Results 
select
  name,
  id,
  workspace_id,
  workspace_url,
  created_date_time,
  sku
from
  azure_databricks_workspace;
+----------------+----------------------------------------------------------------------------------------------------------------------------------------------------+------------------+---------------------------------------------+---------------------------+--------------------+
| name           | id                                                                                                                                                 | workspace_id     | workspace_url                               | created_date_time         | sku                |
+----------------+----------------------------------------------------------------------------------------------------------------------------------------------------+------------------+---------------------------------------------+---------------------------+--------------------+
| workspace-test | /subscriptions/11111111-f95f-6666-bbb5-529d4c76333c/resourceGroups/AzureBackupRG_westus_1/providers/Microsoft.Databricks/workspaces/workspace-test | 7981003590983633 | adb-7981003590983633.13.azuredatabricks.net | 2023-11-01T17:51:35+05:30 | {"name":"premium"} |
+----------------+----------------------------------------------------------------------------------------------------------------------------------------------------+------------------+---------------------------------------------+---------------------------+--------------------+
select
  name,
  id,
  workspace_id,
  workspace_url,
  created_date_time,
  sku
from
  azure_databricks_workspace
where
  name = 'workspace-test'
  and resource_group = 'azurebackuprg_westus_1';
+----------------+----------------------------------------------------------------------------------------------------------------------------------------------------+------------------+---------------------------------------------+---------------------------+--------------------+
| name           | id                                                                                                                                                 | workspace_id     | workspace_url                               | created_date_time         | sku                |
+----------------+----------------------------------------------------------------------------------------------------------------------------------------------------+------------------+---------------------------------------------+---------------------------+--------------------+
| workspace-test | /subscriptions/11111111-f95f-6666-bbb5-529d4c76333c/resourceGroups/AzureBackupRG_westus_1/providers/Microsoft.Databricks/workspaces/workspace-test | 7981003590983633 | adb-7981003590983633.13.azuredatabricks.net | 2023-11-01T17:51:35+05:30 | {"name":"premium"} |
+----------------+----------------------------------------------------------------------------------------------------------------------------------------------------+------------------+---------------------------------------------+---------------------------+--------------------+

@madhushreeray30 madhushreeray30 self-assigned this Nov 1, 2023
@madhushreeray30 madhushreeray30 linked an issue Nov 1, 2023 that may be closed by this pull request
Add table azure_databricks_workspace #691
Closed
misraved
misraved reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madhushreeray30 please take a look at the review comments. Thanks!!

azure/table_azure_databricks_workspace.go Outdated Show resolved Hide resolved
azure/table_azure_databricks_workspace.go Outdated Show resolved Hide resolved
azure/table_azure_databricks_workspace.go Outdated Show resolved Hide resolved
azure/table_azure_databricks_workspace.go Outdated Show resolved Hide resolved
azure/table_azure_databricks_workspace.go Outdated Show resolved Hide resolved
@misraved
Copy link
Contributor

misraved commented Nov 2, 2023

@madhushreeray30 could you please update all instances of Trace logs to Debug?

@misraved misraved merged commit 385853b into main Nov 2, 2023
1 check passed
@misraved misraved deleted the issue-691 branch November 2, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misraved misraved misraved approved these changes

@ParthaI ParthaI Awaiting requested review from ParthaI

Assignees

@madhushreeray30 madhushreeray30

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add table azure_databricks_workspace
2 participants
@madhushreeray30 @misraved