Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table azure_recovery_services_backup_job Closes #663 #681

Merged
merged 13 commits into from
Nov 2, 2023
Merged

Add table azure_recovery_services_backup_job Closes #663 #681

merged 13 commits into from
Nov 2, 2023

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Oct 5, 2023 •
edited
Loading

Integration test logs

Logs 
Add passing integration test logs here

Example query results

Results 
> select name, properties from azure_backup_job where vault_name = 'test43-delete-me'
+--------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------->
| name                                 | properties                                                                                                                                                                                                                          >
+--------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------->
| 4617f498-e84f-4236-9bb1-7dd4f9f3a6f7 | {"ActivityID":"7b55c0e3-38d5-4cc3-b4c8-33215d2ff010","BackupManagementType":"AzureIaasVM","EndTime":"2023-10-06T06:26:51.4907961Z","EntityFriendlyName":"test-backup","JobType":"AzureIaaSVMJob","Operation":"Undelete","StartTime":>
| c4319ff5-9640-4090-84fb-1f70298fc0a5 | {"ActivityID":"7b55c0e3-38d5-4cc3-b4c8-33215d2ff019","BackupManagementType":"AzureIaasVM","EndTime":"2023-10-06T06:27:59.0919188Z","EntityFriendlyName":"test-backup","JobType":"AzureIaaSVMJob","Operation":"DeleteBackupData","Sta>
| 9e81c8ba-df5a-4aa9-8e80-6906f0fecb58 | {"ActivityID":"346be913-6e41-4b61-902a-84993baf10d6","BackupManagementType":"AzureIaasVM","EndTime":"2023-10-04T15:15:45.1782379Z","EntityFriendlyName":"test-backup","JobType":"AzureIaaSVMJob","Operation":"ConfigureBackup","Star>
| 0cde75e9-72d0-403a-9923-12c1baa2fe8f | {"ActivityID":"5c4398d6-45cd-48f1-9593-a3c2e567edae","BackupManagementType":"AzureIaasVM","EndTime":"2023-10-04T18:16:14.6749904Z","EntityFriendlyName":"test-backup","JobType":"AzureIaaSVMJob","Operation":"Backup","StartTime":"2>
| c85988ea-c528-4b91-b683-ae99bdc35d5b | {"ActivityID":"5d3dc4bb-2899-456c-8464-75eb2fe7c017","BackupManagementType":"AzureIaasVM","EndTime":"2023-10-05T10:50:18.7032339Z","EntityFriendlyName":"test-backup","JobType":"AzureIaaSVMJob","Operation":"DisableBackup","StartT>
| 86b76c54-f012-4832-97be-b9c184aa378b | {"ActivityID":"5d3dc4bb-2899-456c-8464-75eb2fe7c025","BackupManagementType":"AzureIaasVM","EndTime":"2023-10-05T10:52:26.74136Z","EntityFriendlyName":"test-backup","JobType":"AzureIaaSVMJob","Operation":"DeleteBackupData","Start>
+--------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------->

@ParthaI ParthaI self-assigned this Oct 5, 2023
@ParthaI ParthaI marked this pull request as draft October 5, 2023 04:53
@ParthaI
Copy link
Contributor Author

ParthaI commented Oct 5, 2023

The PR is in draft state cause of we are encountering an error from Azure Go SDK side while making the API, An issue has been raised on Azure Go SDK side regarding this, once it will get resolved we will comeback to this issue and make it ready for review.

SDK issue reference: Azure/azure-sdk-for-go#21690

@ParthaI ParthaI linked an issue Oct 5, 2023 that may be closed by this pull request
Add table azure_recovery_services_backup_job #663
Closed
@ParthaI ParthaI requested a review from misraved October 6, 2023 07:25
@ParthaI ParthaI marked this pull request as ready for review October 6, 2023 07:25
@ParthaI
Copy link
Contributor Author

ParthaI commented Oct 6, 2023 •
edited
Loading

As per the Azure SDK issue comment, the API is working fine with lated SDK version and it is returning the result as expected. This PR is good to review now. 👍

@ParthaI ParthaI changed the title Add table azure_backup_jobs Closes #663 Add table azure_recovery_services_backup_job Closes #663 Oct 9, 2023
madhushreeray30
madhushreeray30 reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@madhushreeray30 madhushreeray30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthaI Please take a look at the comments, thanks!

azure/table_azure_recovery_services_backup_job.go Outdated Show resolved Hide resolved
azure/table_azure_recovery_services_backup_job.go Outdated Show resolved Hide resolved
@madhushreeray30 madhushreeray30 merged commit 2a80420 into main Nov 2, 2023
1 check passed
@madhushreeray30 madhushreeray30 deleted the issue-663 branch November 2, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhushreeray30 madhushreeray30 madhushreeray30 approved these changes

@misraved misraved Awaiting requested review from misraved

Assignees

@ParthaI ParthaI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add table azure_recovery_services_backup_job
2 participants
@ParthaI @madhushreeray30