-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table azure_kubernetes_service_version Closes #606 #623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthaI please take a look at the review comments. Thanks!!
}, | ||
{ | ||
Name: "id", | ||
Description: "Id of the orchestrator version profile list result.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description: "Id of the orchestrator version profile list result.", | |
Description: "ID of the orchestrator version profile list result.", |
|
||
Azure AKS (Azure Kubernetes Service) orchestrator is a managed container orchestration service provided by Microsoft Azure. It simplifies the deployment, management, and scaling of containerized applications using Kubernetes. AKS allows you to deploy and manage containerized applications without the need to manage the underlying infrastructure. It provides automated Kubernetes upgrades, built-in monitoring and diagnostics, and seamless integration with other Azure services. AKS enables developers and DevOps teams to focus on application development and deployment, while Azure takes care of the underlying Kubernetes infrastructure. | ||
|
||
**Note:** You must need to pass the `location` in where clause to query this table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**Note:** You must need to pass the `location` in where clause to query this table. | |
**Note:** You need to pass the `location` in the where clause to query this table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthaI what was the reasoning behind the naming convention of the table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per terraform we have named it like that: https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/kubernetes_service_versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthaI please take a look at the review comment. Thanks!!
Please make sure that the input parameters are checked correctly for empty values before making the API call.
Also could you please format the example queries using https://www.freeformatter.com/sql-formatter.html#before-output (2 spaces per indent level)?
location := d.EqualsQualString("location") | ||
resourceType := d.EqualsQualString("resource_type") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not check if location
and resourceType
parameters are empty or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@misraved, Thank you for catching that.
- Looking at the list config, the
location
is required in the WHERE clause for querying this table.
KeyColumns: plugin.KeyColumnSlice{
{
Name: "location",
Require: plugin.Required,
},
{
Name: "resource_type",
Require: plugin.Optional,
},
},
- If we do not provide the
location
in the WHERE clause, Steampipe will throw an error stating that thelocation
is required for querying this table. - On the other hand, the
resource_type
is optional in the WHERE clause, meaning we can choose to include it or not. - If we include the
resource_type
in the WHERE clause, the API will filter the response based on the specified value. Otherwise, it will return all resource types.
I don't believe we need to perform any empty checks in this case. Thanks again!
Integration test logs
Logs
Example query results
Results