-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add azure_dns_zone table closes #564 #575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdecat
force-pushed
the
table_azure_dns_zone
branch
2 times, most recently
from
March 12, 2023 11:24
ca81f18
to
86d846e
Compare
pdecat
commented
Mar 12, 2023
pdecat
force-pushed
the
table_azure_dns_zone
branch
from
March 12, 2023 17:31
86d846e
to
3c14704
Compare
pdecat
force-pushed
the
table_azure_dns_zone
branch
2 times, most recently
from
March 13, 2023 16:33
f6ca012
to
329764d
Compare
misraved
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
Co-authored-by: Ved misra <[email protected]>
pdecat
force-pushed
the
table_azure_dns_zone
branch
from
March 15, 2023 12:20
b67c1f1
to
1e8ce6a
Compare
Hi @misraved, I believe I've addressed all your comments. Could you give it another look? 🙏 |
New integration logs:
|
Shr3ps
approved these changes
Mar 15, 2023
misraved
changed the title
Add azure_dns_zone table
Add azure_dns_zone table clsoes #564
Mar 15, 2023
misraved
approved these changes
Mar 15, 2023
misraved
changed the title
Add azure_dns_zone table clsoes #564
Add azure_dns_zone table closes #564
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #564
TODO: