Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table azure_compute_ssh_key #560

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Conversation

srgg
Copy link
Contributor

@srgg srgg commented Jan 16, 2023

Adds support for SSH Publik keys, see https://learn.microsoft.com/en-us/cli/azure/sshkey?view=azure-cli-latest

Example query results

Results
select * from azure_compute_ssh_key;
[
 {
  "_ctx": {
   "connection_name": "azure"
  },
  "akas": [
   "azure:///subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/DEMO_GROUP/providers/Microsoft.Compute/sshPublicKeys/test-key.pub",
  ],
  "cloud_environment": "AzurePublicCloud",
  "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/DEMO_GROUP/providers/Microsoft.Compute/sshPublicKeys/test-key.pub",
  "name": "test-key.pub",
  "public_key": "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQC0XknryLEsmUxhl994+0bUsYJJ2DDTYlMIGNB1MecCAipmifIcF7GQ/heu1rvDjKt1EI8WNhzRbRHHdBWz4t3f3DW9EpVIk0cJKgzdl74T+2i8tP3FDQB5KyNWnqg23MrsY6tU3PubcNYOo1fxXjhWiP1BBavkNQ7kQJ3xBo0nl2xjYpowZ9SqXrwAP2I/0yFUt7JTPt1mDpXeBcYLu/f4wi/owiXdHOxmyS1/Mfs33mBQpFNS4lSMhhF+dO1Z6ToovD5xpDiAXQ/bLc+p4Nu3lRql1ycNHmE4B3zL7YV0v2m9SQDkMf3rrCh8yblMgDtTc8tN0AcOHqWQi36NLGutP9PJqKgqfBzuvNW+AyWgrYYcs0IrFTu2G66ep9KQeJm9d3zc3kV0I/0flxwBxq1H1m7lDLTJUvmvQGk1D20x6GmG1hGpNntwGxyKKnGWR0kvpf48BUnWyfS8gnxXI2UehmFyKAEda2ZUfSsagJMu1EX4u0uN5264DkMZ7pAfq0= [email protected]",
  "region": "eastus",
  "resource_group": "demo_group",
  "subscription_id": "00000000-0000-0000-0000-000000000000",
  "tags": {
   "SimpleTag": "test-upload"
  },
  "title": "test-key.pub",
  "type": null
 }
]

@rajlearner17 rajlearner17 requested a review from misraved January 17, 2023 08:29
@rajlearner17
Copy link
Contributor

@srgg I Appreciate using Steampipe and raising this PR!

We will review this and revert to you if we need further input.

Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srgg for adding this table. The structure looks good 👍.

I have left a few minor review comments, please let me know if you have any questions 👍 .

azure/plugin.go Outdated Show resolved Hide resolved
azure/table_azure_compute_ssh_key.go Outdated Show resolved Hide resolved
docs/tables/table_azure_compute_ssh_key.md Show resolved Hide resolved
azure/table_azure_compute_ssh_key.go Outdated Show resolved Hide resolved
azure/table_azure_compute_ssh_key.go Outdated Show resolved Hide resolved
azure/table_azure_compute_ssh_key.go Outdated Show resolved Hide resolved
azure/table_azure_compute_ssh_key.go Outdated Show resolved Hide resolved
azure/table_azure_compute_ssh_key.go Outdated Show resolved Hide resolved
@rajlearner17
Copy link
Contributor

@srgg Pls lets us know if you have plan to progress on this. Thank you

@srgg
Copy link
Contributor Author

srgg commented Feb 23, 2023

@rajlearner17 Yes, I do have plans. A bit busy. The plan is to update this PR on these weekends, thank you

@srgg
Copy link
Contributor Author

srgg commented Feb 27, 2023

@rajlearner17 @misraved and those who could be interested - PR is updated; the only issue I have with the last review comment. Thanks

@srgg srgg force-pushed the ssh-pubk-support branch from f07807a to 6d3424c Compare March 3, 2023 19:24
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies @srgg for adding incorrect suggestions in the initial round of review. Please make the minor updates to the log messages and then we can go ahead with the release 👍.

azure/table_azure_compute_ssh_key.go Outdated Show resolved Hide resolved
azure/table_azure_compute_ssh_key.go Outdated Show resolved Hide resolved
azure/table_azure_compute_ssh_key.go Outdated Show resolved Hide resolved
azure/table_azure_compute_ssh_key.go Outdated Show resolved Hide resolved
azure/table_azure_compute_ssh_key.go Outdated Show resolved Hide resolved
@srgg srgg force-pushed the ssh-pubk-support branch from 6d3424c to 620cfc9 Compare March 7, 2023 14:17
@srgg
Copy link
Contributor Author

srgg commented Mar 7, 2023

My apologies @srgg for adding incorrect suggestions in the initial round of review. Please make the minor updates to the log messages and then we can go ahead with the release 👍.

@misraved No worries, I've introduced the requested changes. Thank you for the review

@misraved misraved merged commit d8c666c into turbot:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants