Add ignore_error_codes config arg and update all tables to use IgnoreConfig instead of ShouldIgnoreError in GetConfig closes #494 #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig instead of ShouldIgnoreError in GetConfig closes #494
ParthaI
changed the title
azure/errors.go
Outdated
| "github.com/turbot/steampipe-plugin-sdk/v3/plugin" | ||
| ) | ||
|
|
||
| // isNotFoundError:: function which returns an ErrorPredicate for AWS API calls |
There was a problem hiding this comment.
Suggested change
| // isNotFoundError:: function which returns an ErrorPredicate for AWS API calls | |
| // isNotFoundError:: function which returns an ErrorPredicate for Azure API calls |
LalitLab
reviewed
Jun 8, 2022
|
|
||
| # List of additional Azure error codes to ignore for all queries. | ||
| # By default, common not found error codes are ignored and will still be ignored even if this argument is not set. | ||
| #ignore_error_codes = ["NoAuthenticationInformation", "InvalidAuthenticationInfo", "AccountIsDisabled", "UnauthorizedOperation", "UnrecognizedClientException", "AuthorizationError", "AuthenticationFailed", "InsufficientAccountPermissions"] |
There was a problem hiding this comment.
I think the same changes are needed in docs/index.md.
LalitLab
suggested changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test logs
Logs
Example query results
Results
output.txt
output1.txt
azure_policy_assignment: Integration test fix in variables.tf, and get call fixed with
azure_public_ip: Integration test fix
azure_lb_nat_rule: fixed in integration test
azure_app_service_web_app: Hydrated config
azure_compute_virtual_machine: Hydrated config
azure_mssql_elasticpool: Used same package as parent hydrate use
azure_mysql_flexible_server: added parent hydrate as resource_group because the list call was not working without resource group.
table_azure_public_ip: ListAll API call was not working List is working so changed the API call
table_azure_storage_share_file: Empty check logic was wrong changed it