Add table azure_management_group. Closes #456 #460

bigdatasourav · 2022-04-01T08:33:14Z

Integration test logs

Logs

The integration test is not feasible.

Example query results

Results

> select
  id,
  name,
  type,
  tenant_id,
  updated_by
from
  azure_management_group;
+---------------------------------------------------------------------------+--------------------------+---------------------------------------+--------------------------------------+---------------------
| id                                                                        | name                     | type                                  | tenant_id                            | updated_by          
+---------------------------------------------------------------------------+--------------------------+---------------------------------------+--------------------------------------+---------------------
| /providers/Microsoft.Management/managementGroups/morales                  | morales                  | Microsoft.Management/managementGroups | cdffd708-7da0-4cea-abeb-0a4c334d7f64 | d00ae2b0-6317-4fc3-a
| /providers/Microsoft.Management/managementGroups/nagraj                   | nagraj                   | Microsoft.Management/managementGroups | cdffd708-7da0-4cea-abeb-0a4c334d7f64 | d00ae2b0-6317-4fc3-a
| /providers/Microsoft.Management/managementGroups/osborn                   | osborn                   | Microsoft.Management/managementGroups | cdffd708-7da0-4cea-abeb-0a4c334d7f64 | d00ae2b0-6317-4fc3-a
| /providers/Microsoft.Management/managementGroups/newwarriors              | newwarriors              | Microsoft.Management/managementGroups | cdffd708-7da0-4cea-abeb-0a4c334d7f64 | 2f617226-8962-431e-9
| /providers/Microsoft.Management/managementGroups/stacy                    | stacy                    | Microsoft.Management/managementGroups | cdffd708-7da0-4cea-abeb-0a4c334d7f64 | d00ae2b0-6317-4fc3-a
| /providers/Microsoft.Management/managementGroups/daredevil                | daredevil                | Microsoft.Management/managementGroups | cdffd708-7da0-4cea-abeb-0a4c334d7f64 | d00ae2b0-6317-4fc3-a
| /providers/Microsoft.Management/managementGroups/newwarrior-child-mgmtgrp | newwarrior-child-mgmtgrp | Microsoft.Management/managementGroups | cdffd708-7da0-4cea-abeb-0a4c334d7f64 | 2f617226-8962-431e-9
| /providers/Microsoft.Management/managementGroups/parker                   | parker                   | Microsoft.Management/managementGroups | cdffd708-7da0-4cea-abeb-0a4c334d7f64 | d00ae2b0-6317-4fc3-a
| /providers/Microsoft.Management/managementGroups/Punisher                 | Punisher                 | Microsoft.Management/managementGroups | cdffd708-7da0-4cea-abeb-0a4c334d7f64 | 2f617226-8962-431e-9
| /providers/Microsoft.Management/managementGroups/turbot-dev-saas          | turbot-dev-saas          | Microsoft.Management/managementGroups | cdffd708-7da0-4cea-abeb-0a4c334d7f64 | d00ae2b0-6317-4fc3-a
+---------------------------------------------------------------------------+--------------------------+---------------------------------------+--------------------------------------+---------------------


select
	name,
  updated_by,
	jsonb_pretty(children) as children
from
	azure_management_group;
+--------------------------+--------------------------------------+--------------------------------------------------------------------------------------------+
| name                     | updated_by                           | children                                                                                   |
+--------------------------+--------------------------------------+--------------------------------------------------------------------------------------------+
| morales                  | d00ae2b0-6317-4fc3-a828-31fca920448f | [                                                                                          |
|                          |                                      |     {                                                                                      |
|                          |                                      |         "id": "/subscriptions/236a078d-0292-46be-80a3-cd8a1cbccde0",                       |
|                          |                                      |         "name": "236a078d-0292-46be-80a3-cd8a1cbccde0",                                    |
|                          |                                      |         "type": "/subscriptions",                                                          |
|                          |                                      |         "displayName": "morales AAA"                                                       |
|                          |                                      |     }                                                                                      |
|                          |                                      | ]                                                                                          |
| nagraj                   | d00ae2b0-6317-4fc3-a828-31fca920448f | [                                                                                          |
|                          |                                      |     {                                                                                      |
|                          |                                      |         "id": "/subscriptions/d077e537-71c8-4d6e-ae26-56019ef569e2",                       |
|                          |                                      |         "name": "d077e537-71c8-4d6e-ae26-56019ef569e2",                                    |
|                          |                                      |         "type": "/subscriptions",                                                          |
|                          |                                      |         "displayName": "Nagraj AAA"                                                        |
|                          |                                      |     }                                                                                      |
|                          |                                      | ]                                                                                          |
| osborn                   | d00ae2b0-6317-4fc3-a828-31fca920448f | [                                                                                          |
|                          |                                      |     {                                                                                      |
|                          |                                      |         "id": "/subscriptions/ed4b87de-70f6-4d3e-8a37-fe8452c231ea",                       |
|                          |                                      |         "name": "ed4b87de-70f6-4d3e-8a37-fe8452c231ea",                                    |
|                          |                                      |         "type": "/subscriptions",                                                          |
|                          |                                      |         "displayName": "Bulbasaur AAA"                                                     |
|                          |                                      |     }                                                                                      |

…into issue-456

…issue-456

ParthaI

LGTM

misraved · 2022-04-05T11:56:06Z

azure/table_azure_management_group.go

+	}
+
+	// check if name is empty
+	if name == ""{


Suggested change

if name == ""{

if name == "" {

misraved · 2022-04-05T11:56:30Z

azure/table_azure_management_group.go

+
+	// check if name is empty
+	if name == ""{
+		return nil,nil


Suggested change

return nil,nil

return nil,nil

misraved · 2022-04-05T11:57:38Z

docs/tables/azure_management_group.md

+
+Management groups provide a governance scope above subscriptions. You organize subscriptions into management groups in the governance conditions you apply cascade by inheritance to all associated subscriptions. Management groups give you enterprise-grade management at a scale no matter what type of subscriptions you might have. However, all subscriptions within a single management group must trust the same Azure Active Directory (Azure AD) tenant.
+
+Note: To query this table, you need to have read access to the specific management group.


Suggested change

Note: To query this table, you need to have read access to the specific management group.

Note: To query this table, you need to have at least read access to the specific management group.

misraved · 2022-04-05T11:58:04Z

docs/tables/azure_management_group.md

+  azure_management_group;
+```
+
+### List parent detail for management groups


Suggested change

### List parent detail for management groups

### List parent details for management groups

Added New table

2518d3a

bigdatasourav self-assigned this Apr 1, 2022

bigdatasourav and others added 3 commits April 1, 2022 14:11

Update logs

bea2898

Update azure_management_group.md

502ba75

Update table_azure_management_group.go

025d24d

bigdatasourav requested a review from khushboo9024 April 1, 2022 08:48

Update logs

61c1191

bigdatasourav changed the title ~~Add table azure_management_group~~ Add table azure_management_group. Closes #456 Apr 1, 2022

bigdatasourav added 3 commits April 1, 2022 14:32

Merge branch 'issue-456' of github.com:turbot/steampipe-plugin-azure …

3bac25b

…into issue-456

Merge branch 'main' of github.com:turbot/steampipe-plugin-azure into …

fe6f2e1

…issue-456

Update GetNewSession method

f9ebba8

bigdatasourav linked an issue Apr 1, 2022 that may be closed by this pull request

Add table azure_management_group #456

Closed

bigdatasourav requested a review from ParthaI April 5, 2022 05:45

bigdatasourav added 2 commits April 5, 2022 11:18

Update table_azure_management_group.go

b9f7773

Update azure_management_group.md

7e3fe69

ParthaI approved these changes Apr 5, 2022

View reviewed changes

misraved reviewed Apr 5, 2022

View reviewed changes

update

63cc868

misraved approved these changes Apr 5, 2022

View reviewed changes

misraved merged commit 1f0ed92 into main Apr 5, 2022

misraved deleted the issue-456 branch April 5, 2022 12:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add table azure_management_group. Closes #456 #460

Add table azure_management_group. Closes #456 #460

bigdatasourav commented Apr 1, 2022 •

edited

Loading

ParthaI left a comment

misraved Apr 5, 2022

misraved Apr 5, 2022

misraved Apr 5, 2022

misraved Apr 5, 2022


		Management groups provide a governance scope above subscriptions. You organize subscriptions into management groups in the governance conditions you apply cascade by inheritance to all associated subscriptions. Management groups give you enterprise-grade management at a scale no matter what type of subscriptions you might have. However, all subscriptions within a single management group must trust the same Azure Active Directory (Azure AD) tenant.

		Note: To query this table, you need to have read access to the specific management group.

	### List parent detail for management groups
	### List parent details for management groups

Add table azure_management_group. Closes #456 #460

Add table azure_management_group. Closes #456 #460

Conversation

bigdatasourav commented Apr 1, 2022 • edited Loading

Integration test logs

Example query results

ParthaI left a comment

Choose a reason for hiding this comment

misraved Apr 5, 2022

Choose a reason for hiding this comment

misraved Apr 5, 2022

Choose a reason for hiding this comment

misraved Apr 5, 2022

Choose a reason for hiding this comment

misraved Apr 5, 2022

Choose a reason for hiding this comment

bigdatasourav commented Apr 1, 2022 •

edited

Loading