Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename column environment_name to cloud_environment #438

Merged
merged 2 commits into from
Jan 6, 2022

Conversation

misraved
Copy link
Contributor

@misraved misraved commented Jan 6, 2022

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
select
  name,
  access_tier,
  sku_name,
  resource_group, cloud_environment
from
  azure_storage_account;
+------------------------+-------------+----------------+----------------------------------+-------------------+
| name                   | access_tier | sku_name       | resource_group                   | cloud_environment |
+------------------------+-------------+----------------+----------------------------------+-------------------+
| csg10032000527a882b    | Hot         | Standard_LRS   | cloud-shell-storage-centralindia | AzurePublicCloud  |
| testimmutablecontainer | Hot         | Standard_RAGRS | nist-test_group                  | AzurePublicCloud  |
+------------------------+-------------+----------------+----------------------------------+-------------------

@misraved misraved requested a review from cbruno10 January 6, 2022 17:38
@misraved misraved self-assigned this Jan 6, 2022
@misraved misraved changed the title Rename column name environment_name to cloud_environment Rename column environment_name to cloud_environment Jan 6, 2022
Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azure/common_columns.go Show resolved Hide resolved
azure/common_columns.go Outdated Show resolved Hide resolved
azure/monitoring_metric.go Outdated Show resolved Hide resolved
azure/monitoring_metric.go Outdated Show resolved Hide resolved
azure/table_azure_subscription.go Outdated Show resolved Hide resolved
@cbruno10 cbruno10 merged commit 7272e17 into main Jan 6, 2022
@cbruno10 cbruno10 deleted the rename-azure-environment-name-column branch January 6, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants