Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public_network_access and minimal_tls_version column in azure_sql_server table. #371

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Add public_network_access and minimal_tls_version column in azure_sql_server table. #371

merged 2 commits into from
Oct 4, 2021

Conversation

bigdatasourav
Copy link
Contributor

@bigdatasourav bigdatasourav commented Oct 1, 2021 •
edited
Loading

Example query results

Results 
> select jsonb_pretty(server_vulnerability_assessment) as server_vulnerability_assessment, jsonb_pretty(private_endpoint_connections) from azure_sql_server
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| server_vulnerability_assessment                                                                                                                                         | jsonb_pretty                                                                                                                                                                                                                                 |
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| [                                                                                                                                                                       | [                                                                                                                                                                                                                                            |
|     {                                                                                                                                                                   |     {                                                                                                                                                                                                                                        |
|         "id": "/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot_rg/providers/Microsoft.Sql/servers/test3454/vulnerabilityAssessments/Default", |         "PrivateEndpointId": "/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot_rg/providers/Microsoft.Network/privateEndpoints/testpvt-conn",                                                                       |
|         "name": "Default",                                                                                                                                              |         "ProvisioningState": "Ready",                                                                                                                                                                                                        |
|         "type": "Microsoft.Sql/servers/vulnerabilityAssessments",                                                                                                       |         "PrivateEndpointConnectionId": "/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot_rg/providers/Microsoft.Sql/servers/test3454/privateEndpointConnections/testpvt-conn-a964c127-0afc-4de5-a575-5bda52d825a1", |
|         "properties": {                                                                                                                                                 |         "PrivateEndpointConnectionName": "testpvt-conn-a964c127-0afc-4de5-a575-5bda52d825a1",                                                                                                                                                |
|             "recurringScans": {                                                                                                                                         |         "PrivateEndpointConnectionType": "Microsoft.Sql/servers/privateEndpointConnections",                                                                                                                                                 |
|                 "isEnabled": false,                                                                                                                                     |         "PrivateLinkServiceConnectionStateStatus": "Approved",                                                                                                                                                                               |
|                 "emailSubscriptionAdmins": true                                                                                                                         |         "PrivateLinkServiceConnectionStateDescription": "Auto-approved",                                                                                                                                                                     |
|             }                                                                                                                                                           |         "PrivateLinkServiceConnectionStateActionsRequired": "None"                                                                                                                                                                           |
|         }                                                                                                                                                               |     }                                                                                                                                                                                                                                        |
|     }                                                                                                                                                                   | ]                                                                                                                                                                                                                                            |
| ]                                                                                                                                                                       |                                                                                                                                                                                                                                              |
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
> select minimal_tls_version,public_network_access from azure_sql_server
+---------------------+-----------------------+
| minimal_tls_version | public_network_access |
+---------------------+-----------------------+
| 1.0                 | Enabled               |
+---------------------+-----------------------+

@bigdatasourav bigdatasourav requested a review from ParthaI October 1, 2021 15:20
@bigdatasourav bigdatasourav self-assigned this Oct 1, 2021
@bigdatasourav bigdatasourav linked an issue Oct 1, 2021 that may be closed by this pull request
Add public_network_access in azure_sql_server table. #370
Closed
ParthaI
ParthaI approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@ParthaI ParthaI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigdatasourav bigdatasourav merged commit 2ad0e81 into main Oct 4, 2021
@bigdatasourav bigdatasourav deleted the issue-370 branch October 4, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParthaI ParthaI ParthaI approved these changes

Assignees

@bigdatasourav bigdatasourav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add public_network_access in azure_sql_server table.
2 participants
@bigdatasourav @ParthaI