-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tables for monitoring statistics of Virtual Machine cpu utilization and disk read/write ops #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthaI
changed the title
Issue 147
Add tables for monitoring statistics of Virtual Machine cpu utilization and disk read/write ops
Jul 2, 2021
This was
linked to
issues
Jul 2, 2021
Subhajit97
reviewed
Jul 5, 2021
Subhajit97
reviewed
Jul 5, 2021
Subhajit97
reviewed
Jul 5, 2021
Subhajit97
reviewed
Jul 5, 2021
Subhajit97
reviewed
Jul 5, 2021
Subhajit97
reviewed
Jul 5, 2021
Subhajit97
reviewed
Jul 5, 2021
azure/table_azure_compute_virtual_machine_metric_cpu_utilization_daily.go
Outdated
Show resolved
Hide resolved
Subhajit97
reviewed
Jul 5, 2021
azure/table_azure_compute_virtual_machine_metric_cpu_utilization_hourly.go
Outdated
Show resolved
Hide resolved
Subhajit97
reviewed
Jul 5, 2021
Subhajit97
reviewed
Jul 5, 2021
Subhajit97
requested changes
Jul 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthaI Check comments, and update the table descriptions.
Also check description provided in docs.
Subhajit97
reviewed
Jul 5, 2021
Subhajit97
approved these changes
Jul 6, 2021
rajlearner17
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cbruno10
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test logs
Logs
Example query results
Results
Table: azure_compute_virtual_machine_metric_cpu_utilization
Basic Info
CPU Over 0.5% average
Table: azure_compute_virtual_machine_metric_cpu_utilization_hourly
Basic Info
CPU Over 0.5% average
Table: azure_compute_virtual_machine_metric_cpu_utilization_daily
Basic Info
CPU Over 0.4% average
Table: azure_compute_disk_metric_read_ops
Basic Info
Operations Over 1 Bytes average
Table: azure_compute_disk_metric_read_ops_hourly
Basic Info
Operations Over 0.2 Bytes average
Table: azure_compute_disk_metric_read_ops_daily
Basic Info
Operations Over 0.03 Bytes average
Table: azure_compute_disk_metric_write_ops
Basic Info
Operations Over 2 Bytes average
Table: azure_compute_disk_metric_write_ops_hourly
Basic Info
Operations Over 1 Bytes average
Table: azure_compute_disk_metric_write_ops_daily
Basic Info
Operations Over 0.2 Bytes average