Fixed error handling for table_aws_iam_user and table_aws_s3_bucket #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthaI
approved these changes
Oct 23, 2024
misraved
added
the
hacktoberfest-accepted
misraved
approved these changes
Oct 28, 2024
pdecat
reviewed
Nov 7, 2024
| @@ -689,7 +689,7 @@ func getBucketTagging(ctx context.Context, d *plugin.QueryData, h *plugin.Hydrat | |||
|
|
|||
| params := &s3.GetBucketTaggingInput{Bucket: bucketName} | |||
|
|
|||
| bucketTags, _ := svc.GetBucketTagging(ctx, params) | |||
| bucketTags, err := svc.GetBucketTagging(ctx, params) | |||
There was a problem hiding this comment.
This seems to reveal an issue for S3 buckets without tags:
2024-11-07 17:15:06.715 UTC [ERROR] steampipe-plugin-aws.plugin: [ERROR] 1730999705950: table 'aws_s3_bucket' failed to get column data: table 'aws_s3_bucket' column 'tags_src' requires hydrate data from getBucketTagging, which failed with error operation error S3: GetBucketTagging, https response error StatusCode: 404, RequestID: ******, HostID: ******, api error NoSuchTagSet: The TagSet does not exist.
GetBucketTagginghas the following special error:
Error code:NoSuchTagSet
Description: There is no tag set associated with the bucket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error handling for some APIs for the
table_aws_iam_userandtable_aws_s3_buckettable. If an error occurs (e.g., missing permissions for the respective API), a nil pointer dereference error is thrown.Integration test logs
Logs
Example query results
Results