Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix space in build config #332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Try to fix space in build config #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build/DotnetValidation/DotnetValidation.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFrameworks>net20;net30;net35;net35-cf;net40;net45;netcoreapp1.1;portable40-net40+sl5+win8+wp8+wpa81</TargetFrameworks>
<EnableDefaultNoneItems>False</EnableDefaultNoneItems>
<Antlr4UseCSharpGenerator>True</Antlr4UseCSharpGenerator>
<Configurations>Debug;Release;New Config With Space</Configurations>
</PropertyGroup>

<Choose>
Expand Down
7 changes: 5 additions & 2 deletions build/DotnetValidation/DotnetValidation.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 15
VisualStudioVersion = 15.0.26621.2
# Visual Studio Version 16
VisualStudioVersion = 16.0.28803.202
MinimumVisualStudioVersion = 10.0.40219.1
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "DotnetValidation", "DotnetValidation.csproj", "{E1557B8D-28E5-4D82-AD1F-F483CD8ED931}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
New Config With Space|Any CPU = New Config With Space|Any CPU
Release|Any CPU = Release|Any CPU
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{E1557B8D-28E5-4D82-AD1F-F483CD8ED931}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{E1557B8D-28E5-4D82-AD1F-F483CD8ED931}.Debug|Any CPU.Build.0 = Debug|Any CPU
{E1557B8D-28E5-4D82-AD1F-F483CD8ED931}.New Config With Space|Any CPU.ActiveCfg = New Config With Space|Any CPU
{E1557B8D-28E5-4D82-AD1F-F483CD8ED931}.New Config With Space|Any CPU.Build.0 = New Config With Space|Any CPU
{E1557B8D-28E5-4D82-AD1F-F483CD8ED931}.Release|Any CPU.ActiveCfg = Release|Any CPU
{E1557B8D-28E5-4D82-AD1F-F483CD8ED931}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
Expand Down
5 changes: 3 additions & 2 deletions runtime/CSharp/Antlr4BuildTasks/Antlr4ClassGenerationTaskInternal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,9 @@ public bool Execute()
}

arguments.Add("-o");
arguments.Add(OutputPath);

// Wrap output path with quotes to work with cmdline
arguments.Add("\""+ OutputPath + "\"");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is obviously not right, as JoinArguments is supposed to append quotes to arguments with spaces.


if (!string.IsNullOrEmpty(Encoding))
{
arguments.Add("-encoding");
Expand Down