Try to fix space in build config #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahk-ivanov
reviewed
Jul 18, 2019
| arguments.Add(OutputPath); | ||
|
|
||
| // Wrap output path with quotes to work with cmdline | ||
| arguments.Add("\""+ OutputPath + "\""); |
There was a problem hiding this comment.
This is obviously not right, as JoinArguments is supposed to append quotes to arguments with spaces.
sharwell
requested changes
Aug 7, 2019
Local builds are fairly complex, but the CI should be working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #320, but i didn't get the build work on my laptop.
I hope there will some kind of CI to help me to verify, which doesn't seem to be true.
So @sharwell can you help try this out, or can you point me out, how to build\test\run this locally.