Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check if an object is pickable #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not check if an object is pickable #47

wants to merge 1 commit into from

Conversation

mkardas
Copy link

@mkardas mkardas commented Dec 6, 2022

Title

  • Speed up results serialization

Description

  • This implements the easiest solution to Speed up results serialization #46 by simply removing the check. It wasn't tested with python 3.6 (which uses standalone dataclasses lib). It may break on dynamically created dataclasses.

Linked Issues

@hyunwoongko
Copy link
Contributor

I will test this in near future, and if it worked well, I will merge it.
thanks for great PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speed up results serialization
2 participants
@mkardas @hyunwoongko