Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dismiss delegate methods #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

danqing
Copy link

@danqing danqing commented Mar 9, 2020

I'd like to get notified when the viewer is dismissed interactively. Currently there's no way to get notified.

The reason I need it is I'm playing video in the photo viewer, and I want to stop it when the viewer is dismissed.

@tungvoduc
Copy link
Owner

@danqing I think you can easily achieve that by subclassing DTPhotoViewerController and override method dismiss(animated:, completion:). I am not sure if delegate methods is necessary.

@danqing
Copy link
Author

danqing commented Mar 9, 2020

How should I override that method? I want to be notified when the viewer is dismissed and I feel like a delegate method is the best way to do it. Is there any downside of adding a new delegate method?

@danqing
Copy link
Author

danqing commented Sep 5, 2021

Hi @tungvoduc — it's been a while. Any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants