-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: do not redirect if target domain is the same as source #29
Comments
The issue you linked is something over complicated than I was thinking about. I'm not sure what you are after with this. |
Sorry, I was AWOL for last days. |
That may be doable, but not in my top priority. Sorry.. |
I am not trying to make this request top priority. ;) |
Well, I leave it open and add help wanted tag for it :) Also do you have more examples to share? The issue you linked discusses particularly one single use case for "amazon.com" domain. For this particular case URL redirection filtering should not be applied if both the request URL and the filtered redirection URL are both subdomains of the same main domain "amazon.com". |
And how about the multiple top level domains of the same service, like Amazon and Google? Do you require that they are treated as same domain, too? |
Is that even possible? |
About examples... I can throw them here when I will stumble on them, but quite a lot of login pages are cowered out of the box with this solution. |
Ok, I leave it open if some one wants to work on it. |
Uses tldjs for domain name parsing. implements #29
1.11.0 has support for this. |
Don't know how to explain this, but will try.
Can you implement exception checkbox under redirect rule, where redirection would not take place if the redirected domain is the same as source... see debate here sblask-webextensions/webextension-skip-redirect#30 (comment)
The text was updated successfully, but these errors were encountered: