Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to AndroidX #23

Merged
merged 1 commit into from
Sep 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backboard-example/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ android {
}

dependencies {
compile rootProject.ext.facebookRebound
compile project(':backboard')
compile fileTree(dir: 'libs', include: ['*.jar'])
implementation rootProject.ext.facebookRebound
implementation project(':backboard')
implementation fileTree(dir: 'libs', include: ['*.jar'])
}
2 changes: 1 addition & 1 deletion backboard-example/src/main/res/values/colors.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@
<item>@drawable/circle_gray</item>
</array>

</resources>
</resources>
38 changes: 19 additions & 19 deletions backboard/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,19 @@ android {
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.txt'
}
}
}

dependencies {
provided rootProject.ext.facebookRebound
compile rootProject.ext.supportAnnotation

compile fileTree(dir: 'libs', include: ['*.jar'])
libraryVariants.all { variant ->
task("javadoc${variant.name}", type: Javadoc) {
source = variant.javaCompile.source
ext.androidJar = "${android.sdkDirectory}/platforms/${android.compileSdkVersion}/android.jar"
classpath = files(android.sourceSets.main.java.srcDirs) + files(ext.androidJar)
options.links("http://docs.oracle.com/javase/7/docs/api/")
options.linksOffline("http://developer.android.com/reference/", "${android.sdkDirectory}/docs/reference/")
options.links("http://facebook.github.io/rebound/javadocs/")
exclude '**/BuildConfig.java'
exclude '**/R.java'
}
}
}

checkstyle {
Expand All @@ -72,19 +78,6 @@ task checkstyle(type: Checkstyle) {

check.dependsOn 'checkstyle'

android.libraryVariants.all { variant ->
task("javadoc${variant.name}", type: Javadoc) {
source = variant.javaCompile.source
ext.androidJar = "${android.sdkDirectory}/platforms/${android.compileSdkVersion}/android.jar"
classpath = files(variant.javaCompile.classpath.files) + files(ext.androidJar)
options.links("http://docs.oracle.com/javase/7/docs/api/")
options.linksOffline("http://developer.android.com/reference/", "${android.sdkDirectory}/docs/reference/")
options.links("http://facebook.github.io/rebound/javadocs/")
exclude '**/BuildConfig.java'
exclude '**/R.java'
}
}

// disable insane, build-breaking doclint tool in Java 8
if (JavaVersion.current().isJava8Compatible()) {
tasks.withType(Javadoc) {
Expand All @@ -93,5 +86,12 @@ if (JavaVersion.current().isJava8Compatible()) {
}
}

dependencies {
implementation rootProject.ext.facebookRebound
implementation rootProject.ext.supportAnnotation

implementation fileTree(dir: 'libs', include: ['*.jar'])
}

apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/installv1.gradle'
apply from: 'bintrayv1.gradle'
6 changes: 4 additions & 2 deletions backboard/src/main/java/com/tumblr/backboard/Actor.java
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
package com.tumblr.backboard;

import android.annotation.SuppressLint;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.util.Property;
import android.view.MotionEvent;
import android.view.View;
import android.view.ViewConfiguration;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;

import com.facebook.rebound.Spring;
import com.facebook.rebound.SpringListener;
import com.facebook.rebound.SpringSystem;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
package com.tumblr.backboard;

import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.util.Property;
import android.view.MotionEvent;
import android.view.View;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;

/**
* Used by {@link com.tumblr.backboard.Actor} and
* {@link com.tumblr.backboard.imitator.MotionImitator} to determine which axis to use when mapping
Expand Down Expand Up @@ -130,4 +131,4 @@ public float getOffset(@Nullable final View view) {

return 0;
}
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package com.tumblr.backboard.imitator;

import android.support.annotation.NonNull;
import android.view.MotionEvent;

import androidx.annotation.NonNull;

import com.tumblr.backboard.MotionProperty;

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package com.tumblr.backboard.imitator;

import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.view.MotionEvent;
import android.view.View;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;

import com.facebook.rebound.Spring;

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.tumblr.backboard.imitator;

import android.support.annotation.NonNull;
import androidx.annotation.NonNull;

import com.facebook.rebound.Spring;

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package com.tumblr.backboard.imitator;

import android.support.annotation.NonNull;
import android.view.MotionEvent;

import androidx.annotation.NonNull;

import com.facebook.rebound.Spring;
import com.facebook.rebound.SpringConfig;
import com.facebook.rebound.SpringListener;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
package com.tumblr.backboard.imitator;

import android.support.annotation.NonNull;
import android.view.MotionEvent;
import android.view.View;

import androidx.annotation.NonNull;

import com.facebook.rebound.Spring;
import com.tumblr.backboard.MotionProperty;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.tumblr.backboard.imitator;

import android.support.annotation.NonNull;
import androidx.annotation.NonNull;

import com.facebook.rebound.Spring;
import com.facebook.rebound.SpringListener;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package com.tumblr.backboard.imitator;

import android.annotation.SuppressLint;
import android.support.annotation.NonNull;
import android.view.MotionEvent;
import android.view.View;

import androidx.annotation.NonNull;

import com.facebook.rebound.Spring;

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
package com.tumblr.backboard.performer;

import android.support.annotation.NonNull;
import android.util.Property;
import android.view.View;

import androidx.annotation.NonNull;

import com.facebook.rebound.Spring;
import com.facebook.rebound.SpringUtil;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package com.tumblr.backboard.performer;

import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.util.Property;
import android.view.View;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;

import com.facebook.rebound.Spring;
import com.facebook.rebound.SpringListener;

Expand Down
12 changes: 7 additions & 5 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@

buildscript {
repositories {
google()
jcenter()
}
dependencies {

classpath 'com.android.tools.build:gradle:2.2.2'
classpath 'com.android.tools.build:gradle:4.0.1'
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.2'
classpath 'com.github.dcendents:android-maven-gradle-plugin:1.4.1'

Expand All @@ -30,15 +31,16 @@ buildscript {

allprojects {
repositories {
google()
jcenter()
}
}

ext {
buildToolsVersion = "23.0.2"
compileSdkVersion = 23
buildToolsVersion = "30.0.2"
compileSdkVersion = 28
minSdkVersion = 14
targetSdkVersion = 23
supportAnnotation = "com.android.support:support-annotations:23.0.1"
targetSdkVersion = 28
supportAnnotation = 'androidx.annotation:annotation:1.0.0'
facebookRebound = "com.facebook.rebound:rebound:0.3.8"
}
3 changes: 0 additions & 3 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,3 @@
# This option should only be used with decoupled projects. More details, visit
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
# org.gradle.parallel=true
project.ext {
localBuildTools.com.android.tools.build:gradle:0.14.1
}
4 changes: 2 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Fri Oct 21 15:19:26 EDT 2016
#Wed Sep 02 14:43:29 PDT 2020
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-2.14.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-6.1.1-all.zip