Producer is stuck in DISCONNECTING state if inflight request is timed out during disconnect procedure #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… out during disconnect procedure
Saeger
approved these changes
Oct 29, 2021
Nevon
approved these changes
Nov 22, 2021
|
Thank you for the contribution. Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1167
Scenario:
enforceRequestTimeout=true
Producer has inflight request
producer.disconnect() is called. RequestQueue::waitForPendingRequests wait's for queue to be empty.
Inflight request is failed due to timeout
In this case producer is stuck in DISCONNECTING state if inflight request is timed out during disconnect procedure.
Fix
RequestQueue now tries to emit REQUEST_QUEUE_EMPTY in case of request timeout